Closed
Bug 1514704
Opened 5 years ago
Closed 5 years ago
Initial gray marking time is not attributed to correct stats phase
Categories
(Core :: JavaScript: GC, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
1.99 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Following the incremental gray marking changes, the time taken to mark through from the gray roots is not attributed to the SWEEP_MARK_GRAY phase but just to the parent, SWEEP_MARK.
|
Assignee | |
Comment 1•5 years ago
|
||
Patch to fix this. Also I made GCRuntime::markIncomingCrossCompartmentPointers not depend on the numeric value of MarkColor in choosing which phase to use.
Attachment #9031816 -
Flags: review?(sphink)
|
||
Updated•5 years ago
|
Attachment #9031816 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fd169181a978 Attribute initial gray marking time to correct stats phase r=sfink
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd169181a978
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•