Update color prefs to allow customizing Windows 10 titlebar accent color

RESOLVED FIXED in Firefox 65

Status

()

defect
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: ke5trel, Assigned: ke5trel)

Tracking

(Depends on 1 bug, {regression})

66 Branch
mozilla66
Unspecified
Windows 10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 fixed, firefox66 fixed)

Details

Attachments

(1 attachment)

Since Bug 1503306 has applied the Windows 10 accent color to all built-in themes it would be nice to be able to alter it with a pref. This would normally be possible with nsXPLookAndFeel::sColorPrefs but Bug 1344910 did not update it to include the new accent color IDs.

> ui.-moz-win-accentcolor
> ui.-moz-win-accentcolortext
Component: Theme → Widget
Product: Firefox → Core
Hi Jim, can you please look at the review request for this when you get a chance? We've only got a couple weeks left for uplifting patches for 65 before it goes to RC.
Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34d4a5081960
Update color prefs for new color IDs including -moz-win-accentcolor r=jmathies
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(ke5trel)

Comment on attachment 9031827 [details]
Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1503306

User impact if declined: User can no longer disable/control the titlebar accent color for the built-in themes independently of the OS setting.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Only adds three additional hidden color preferences that do nothing unless the user manually creates them.

String changes made/needed:

Flags: needinfo?(ke5trel)
Attachment #9031827 - Flags: approval-mozilla-beta?

Comment on attachment 9031827 [details]
Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor

[Triage Comment]
Allows users to modify the accent color of the titlebar for built-in themes independent of the OS setting. Approved for 65.0b11.

Attachment #9031827 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
See Also: → 1504766
Depends on: 1524279
You need to log in before you can comment on or make changes to this bug.