Closed Bug 1514725 Opened 8 months ago Closed 8 months ago

Fix tabs API for WebExtensions after bug 1345474

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 66.0

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Bug 1345474 added a new property to the `TabBase` object so Thunderbird needs to add an override for it.
Attached patch Proposed patchSplinter Review
Attachment #9031839 - Flags: review?(geoff)
Do we need to do the same to window?
Flags: needinfo?(neil)
Comment on attachment 9031839 [details] [diff] [review]
Proposed patch

Okay, a bit of digging reveals this shouldn't be necessary on Window.
Flags: needinfo?(neil)
Attachment #9031839 - Flags: review?(geoff) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/68b96cf5813e
Add 'canAccessTab' to tabs API for WebExtensions after bug 1345474; r=darktrojan
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Thank you Neil.
Target Milestone: --- → Thunderbird 66.0
Looks like Neil was the author here, but since his details were missing from the patch, Geoff is now author and reviewer :-)
(In reply to Geoff Lankow from comment #2)
> Do we need to do the same to window?

Sorry I didn't know, all I knew is that this fix was enough to get the tabs API working on trunk again.

(In reply to Jorg K (GMT+1) from comment #6)
> Looks like Neil was the author here, but since his details were missing from
> the patch, Geoff is now author and reviewer :-)

Ugh, and I went to all the trouble of providing a commit message too...
You need to log in before you can comment on or make changes to this bug.