Closed Bug 151474 Opened 22 years ago Closed 22 years ago

"onOK" should be "onAccept" in Color Picker for doubleclick color seletion

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows 95
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: neil, Assigned: cmanske)

References

Details

(Keywords: polish, regression, Whiteboard: [fixed in trunk][adt2 RTM][verified-trunk])

Attachments

(1 file)

Proposed patch
432 bytes, patch
Brade
: review+
alecf
: superreview+
jesup
: approval+
Details | Diff | Splinter Review 
Steps to reproduce problem:
1. Open a colour picker e.g. Format/Text Colour
2. Double-click on a colour cell

Expected results: dialog closes

Actual results: JS error
Attached patch Proposed patch — — Splinter Review 

    
    

    
  
Oops, forgot to set owner :-(
Assignee: syd → cmanske
Keywords: patch, 
          
            polish, 
          
            review, 
          
            ui

    
  

        Attachment #87492 -
        Flags: review+

    
    

    
  
Comment on attachment 87492 [details] [diff] [review]
Proposed patch

r=brade

    
  
Keywords: nsbeta1+
Whiteboard: [FIX IN HAND][need sr=][adt2 RTM]

    
    

    
  
This was obviously caused by converting "onOk" methods to "onAccept" and the
doublclick handler wasn't changed.

Status: NEW → ASSIGNED
Keywords: regression
Summary: Error: onOK is not defined → "onOK" should be "onAccept" in Color Picker for doubleclick color seletion
Target Milestone: --- → mozilla1.0.1

    
    

    
  
Comment on attachment 87492 [details] [diff] [review]
Proposed patch

sr=alecf

        Attachment #87492 -
        Flags: superreview+

    
    

    
  
fixed in trunk
Nominating to be fixed in branch.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: adt1.0.1, 
          
            mozilla1.0.1
Resolution: --- → FIXED
Whiteboard: [FIX IN HAND][need sr=][adt2 RTM] → [fixed in trunk][adt2 RTM]

    
    

    
  
verified on trunk 0617. 
Whiteboard: [fixed in trunk][adt2 RTM] → [fixed in trunk][adt2 RTM][verified-trunk]

    
    

    
  
adding adt1.0.1+.  Please get drivers approval before checking into the branch.
Keywords: adt1.0.1 → adt1.0.1+

    
    

    
  
*** Bug 123790 has been marked as a duplicate of this bug. ***

    
    

    
  
Comment on attachment 87492 [details] [diff] [review]
Proposed patch

Approval granted for 1.0 branch checkin; please remove the mozilla1.0.1+
keyword when this is fixed and add the fixed 1.0.1 keyword.

        Attachment #87492 -
        Flags: approval+

    
    

    
  
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+

    
    

    
  
checked into mozilla1.0.1 branch
Keywords: mozilla1.0.1+ → fixed1.0.1

    
    

    
  
verified in 7/17 branch build.
Status: RESOLVED → VERIFIED
Keywords: verified1.0.1

    
  
Keywords: fixed1.0.1
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: