Closed Bug 1514760 Opened 10 months ago Closed 10 months ago

Debugger variables cannot be expanded when re-paused

Categories

(DevTools :: Debugger, defect)

defect
Not set

Tracking

(firefox65 verified, firefox66 verified)

VERIFIED FIXED
Firefox 66
Tracking Status
firefox65 --- verified
firefox66 --- verified

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(2 files)

STR:

1. go to https://nutritious-fork.glitch.me/
2. expand a and expand a's second item (b)
3. resume / pause


ER: a's first value should be "foo"
AR: a's first value is 1


ER: a's second item is expanded with value "bar"
AR: a's second item cannot be expanded
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f6c4e398f47
Debugger variables cannot be expanded when re-paused. r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/0f6c4e398f47
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Assignee: nobody → jlaster
[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1491471

User impact if declined: the debugger's variables panel does not work the second time users pause in the same function.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): it only affects the debugger

String changes made/needed:
Attachment #9032421 - Flags: approval-mozilla-beta?
Comment on attachment 9032421 [details] [diff] [review]
beta-scopes.patch

[Triage Comment]
Fixes issues with the debugger panel when pausing twice in the same function. Thanks for including tests. Approved for 65.0b6.
Attachment #9032421 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I have managed to reproduce this issue on an affected Firefox 65.0b4 build using Windows 10x64  by following the STR from comment 0. 

This issue is verified fixed using Firefox 65.0b6 and Firefox 66.0a1 (20181220215605) on the following OSes: Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.