66.0a1 (2018-12-15) (64-bit) - "Restart to update Daily" button on "About Thunderbird Daily" dialog does nothing

VERIFIED FIXED in Thunderbird 66.0

Status

defect
VERIFIED FIXED
7 months ago
7 months ago

People

(Reporter: bugzilla.mozilla.org, Assigned: Paenglab)

Tracking

Thunderbird 66.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird65 fixed, thunderbird66 fixed)

Details

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

1. Bring up Thunderbird Daily 66.0a1 (2018-12-15) (64-bit)
2. Select Menu->Help->About Thunderbird Daily
3. Click the Update button
4. When "Restart to update Daily" button appears, click on it

This happened when I updated to the 66.0a1 (2018-12-15) release yesterday as well


Actual results:

Nothing.

The "About Thunderbird Daily" dialog with the "Restart to update Daily" button just sits there.

I have to manually exit the app and start it up again


Expected results:

It should restart
Component: Untriaged → General
I get this error in console:

TypeError: panel is null[Learn More] aboutDialog-appUpdater.js:150:9

selectPanel chrome://messenger/content/aboutDialog-appUpdater.js:150
buttonRestartAfterDownload chrome://messenger/content/aboutDialog-appUpdater.js:202
oncommand chrome://messenger/content/aboutDialog.xul:1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Jörg, it seems we missed this panel with your syncing of the file.

65.b1 probably shouldn't be published without this patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9032142 - Flags: review?(jorgk)
Attachment #9032142 - Flags: approval-comm-beta?
Blocks: 1510798
Comment on attachment 9032142 [details] [diff] [review]
1514772-update-dialog-fix.patch

I haven't tested, I trust you did. Change looks reasonable.

What happens if you just close TB without clicking the button? It updates on next start?
Attachment #9032142 - Flags: review?(jorgk)
Attachment #9032142 - Flags: review+
Attachment #9032142 - Flags: approval-comm-beta?
Attachment #9032142 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7b1a013aaddb
Add missing "restarting" panel to the update dialogs. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
I haven't tested too. It's a bit hard to test with a self built TB.

Yes, closing TB and it updates when newly started.
Well, maybe that's not so bad then. People will know to restart manually if the button doesn't work. I can put it into the release notes. I'd be better to test if for real instead of holding up the beta for it.
Can you check that yesterday's Daily works and updates to today's.
It's planned. But it will be in the evening.
Faster than I thought. It works.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.