1514772 - 66.0a1 (2018-12-15) (64-bit) - "Restart to update Daily" button on "About Thunderbird Daily" dialog does nothing

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Mark Barnes]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

1. Bring up Thunderbird Daily 66.0a1 (2018-12-15) (64-bit)
2. Select Menu->Help->About Thunderbird Daily
3. Click the Update button
4. When "Restart to update Daily" button appears, click on it

This happened when I updated to the 66.0a1 (2018-12-15) release yesterday as well


Actual results:

Nothing.

The "About Thunderbird Daily" dialog with the "Restart to update Daily" button just sits there.

I have to manually exit the app and start it up again


Expected results:

It should restart

Comment 1

[Richard Marti (:Paenglab)]

I get this error in console:

TypeError: panel is null[Learn More] aboutDialog-appUpdater.js:150:9

selectPanel chrome://messenger/content/aboutDialog-appUpdater.js:150
buttonRestartAfterDownload chrome://messenger/content/aboutDialog-appUpdater.js:202
oncommand chrome://messenger/content/aboutDialog.xul:1

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1514772-update-dialog-fix.patch

Jörg, it seems we missed this panel with your syncing of the file.

65.b1 probably shouldn't be published without this patch.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9032142 [details] [diff] [review]
1514772-update-dialog-fix.patch

I haven't tested, I trust you did. Change looks reasonable.

What happens if you just close TB without clicking the button? It updates on next start?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7b1a013aaddb
Add missing "restarting" panel to the update dialogs. r=jorgk

Comment 5

[Richard Marti (:Paenglab)]

I haven't tested too. It's a bit hard to test with a self built TB.

Yes, closing TB and it updates when newly started.

Comment 6

[Jorg K (CEST = GMT+2)]

Well, maybe that's not so bad then. People will know to restart manually if the button doesn't work. I can put it into the release notes. I'd be better to test if for real instead of holding up the beta for it.

Comment 7

[Jorg K (CEST = GMT+2)]

Can you check that yesterday's Daily works and updates to today's.

Comment 8

[Richard Marti (:Paenglab)]

It's planned. But it will be in the evening.

Comment 9

[Jorg K (CEST = GMT+2)]

Beta (TB 65):
https://hg.mozilla.org/releases/comm-beta/rev/6e4ca7bc98b5066178f61791e44d374484b6eedc

Comment 10

[Richard Marti (:Paenglab)]

Faster than I thought. It works.