1514908 - Make WorkerRef take an rvalue reference to its callback

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P2)

Description

[Blake Kaplan (:mrbkap) (inactive)]

StrongWorkerRef::Create and WeakWorkerRef::Create currently take a const reference to the callback and copy it around. Given that pretty much all of the closures passed to these functions capture RefPtrs to atomically refcounted objects, it seems worth the effort to reduce the number of copies. We can do that with rvalue references and std::move.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e598d84bded98369dfebbe5243664143c3c1b6a8

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1514908 - Reduce deep copies of the closures passed to this function. r=baku

By taking an rvalue reference and using std::move more aggressively, we can
avoid at least two copies of these closures, which avoids a bit of atomic
refcounting.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3359ea05f0ee
Reduce deep copies of the closures passed to this function. r=baku

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3359ea05f0ee