1515008 - [remote-dbg-next] Move devtools/shared/adb to devtools/client/shared/adb

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

ADB should only be used on the client, in order to connect to remote servers. Also it has dependencies on client files, which will not be available if only server & shared are available.

Comment 1

[Julian Descottes [:jdescottes]]

We might even move it to devtools/client/shared/remote-debugging . Another file probably worth moving there is the connection-manager.js [1]. Having all the modules dedicated to remote debugging in the same place will probably help identifying duplicates.

[1] https://searchfox.org/mozilla-central/source/devtools/shared/client/connection-manager.js

Comment 2

[Julian Descottes [:jdescottes]]

filter on: remote-debugging-m2-reserve-cleanup

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1515008 - Move adb from devtools/shared to devtools/client/shared/remote-debugging

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1515008 - Move connection-manager from devtools/shared to devtools/client/shared/remote-debugging

Depends on D68598

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ff6b5ab2bc2
Move adb from devtools/shared to devtools/client/shared/remote-debugging r=daisuke
https://hg.mozilla.org/integration/autoland/rev/5cd36a310964
Move connection-manager from devtools/shared to devtools/client/shared/remote-debugging r=daisuke

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0ff6b5ab2bc2
https://hg.mozilla.org/mozilla-central/rev/5cd36a310964