1515014 - Installer fails to find .INI file if -ms occurs after it on command line

Status: NEW

(Firefox :: Installer, defect, P3)

Description

[u630187]

Attachment: firefox_setup.ini

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

-Install Firefox with following Param and cmd:
C:\Users\username>"\\path\Firefox Setup 64.exe" /INI=C:\firefox_setu
p.ini -ms


Actual results:

Firefox creates Desktop shortcut even though DesktopShortcut=false in firefox_setu
p.ini.


Expected results:

Firefox shouldnt create DEsktop shourtcut

Comment 1

[Rares Doghi, Desktop QA]

Hi, I managed to reproduce this issue In all version of Firefox from release to beta as well as Nightly 66.0a1 (2018-12-27), everytime I install Firefox regardless of the settings I set in the Ini file, that file is just not considered, Im using the settings from this page https://wiki.mozilla.org/Installer:Command_Line_Arguments.

C:\Users\user.name\Desktop\Mozilla\Firefox_Setup_64.0.exe /INI=C:\firefox_setup.ini -ms

am I missing something here ? The Firefox Installs in the Background but its installing with default settings

This is how my ini file looks like:

[Install]

; Remove the semicolon (;) to un-comment a line.

 InstallDirectoryName=Mozilla

 InstallDirectoryPath=C:\Users\user.name\Desktop\Release

 QuickLaunchShortcut=false

 TaskbarShortcut=false

 DesktopShortcut=false

 StartMenuShortcuts=false

 StartMenuDirectoryName=Mozilla

 MaintenanceService=false

 OptionalExtensions=false

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Thanks for the confirmation. Can you verify whether the problem goes away if you either remove the -ms or move it to before the /INI on the command line? It looks like the issue is that our command line parser doesn't recognize that -ms is a separate argument and tries to treat it as part of the file name.

Note that -ms or /S isn't necessary to add at all if any other command line parameter is also being used.

Comment 3

[Rares Doghi, Desktop QA]

Hello Matt, I rechecked this issue without the -ms as well as with the -ms before the /INI command and it worked great, not only that the Firefox Icon was not created on desktop but also the Installation folder was the one I mentioned in the ini file.

Glad you got to the bottom of this.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Okay, thanks for checking that.

Unfortunately the bug is happening in library code provided by the framework (the GetOptions macro in FileFunc.nsh), so this may not be something we can fix. The best workaround might be just to remove the mention of -ms from the documentation and declare it to be unsupported.