1515026 - No telemetry pings are sent if the stage 1 button or the "Dismiss" button from certain snippets are clicked

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 65.0b4 and above

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have the latest Firefox Nightly build installed.
- Have the "Browser Console" opened.
- Have a Firefox profile with the following prefs in the "about:config" page:
	- "browser.newtabpage.activity-stream.asrouterExperimentEnabled" with "true" value;
	- "browser.ping-centre.log" set to "true".

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Navigate to "about:config#asrouter" page.
3. Scroll down to the "NEWSLETTER_TEST_1" section and click the "Show" button.
4. Focus the "Browser Console" and clear all the output from it.
5. Go back to the "AS Router" page and click the snippet's "Continue" button.
6. Focus the "Browser Console" and observe the displayed pings.

[Expected result]:
- A specific ping is displayed in the "Browser Console".

[Actual result]:
- No pings are displayed.

[Additional Notes]:
- This issue is also reproducible with the "FXA_SNIPPET_TEST_1" and the "SNIPPETS_SEND_TO_DEVICE_TEST" snippets.
- According to the "QA plan for ASR Snippets" doc (https://goo.gl/KCLbkM), a specific ping should be displayed in the "Browser Console".
- Attached a screen recording of the issue.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4ec4f4bb06d982a2e4056f8bf736d03d6d486437
Fix Bug 1515026 - Send telemetry ping for dismiss events (#4634)

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Per discussion with tspurway, the severity of this bug doesn't warrant tracking for the 65 release, but I'll consider an uplift request still if the patch is low-risk.

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/bd9fccec51d7

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue and it seems that is partially fixed. The pings are correctly sent for the "Dismiss" button, but there are still no pings sent for the stage 1 button.

Considering the above I am reopening the issue.

Tested with the latest Firefox Nightly (66.0a1 Build ID - 20190108215840) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4648

Comment 6

[Ed Lee :Mardak]

https://github.com/mozilla/activity-stream/commit/8b65268c67a702262a4b26352bfdfba459943323

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/226b130b6360

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider backporting to Beta?

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4663

Comment 10

[Andrei Oprea [:andreio]]

Attachment: Bug 1515026 - Add telemetry pings for missing AS Snippets user actions

Comment 11

[Andrei Oprea [:andreio]]

More telemetry is always good.
Patch is up https://phabricator.services.mozilla.com/D16698
I reached out to QA to get this verified before requesting uplift.

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (66.0a1 Build ID - 20190116093310) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now a telemetry ping is sent after the "Stage 1" button is clicked.

Comment 13

[Andrei Oprea [:andreio]]

Comment on attachment 9036914 [details]
Bug 1515026 - Add telemetry pings for missing AS Snippets user actions

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1513279

User impact if declined: Missing user telemetry data for Snippets user actions

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: Already verified

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Small patch already verified by QA

String changes made/needed:

Comment 14

[Ryan VanderMeulen [:RyanVM]]

We should still verify this on Beta.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9036914 [details]
Bug 1515026 - Add telemetry pings for missing AS Snippets user actions

[Triage Comment]
Adds more telemetry probes for AS Snippets, which are going out enabled by default in Fx65. Approved for 65.0b12.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a50ebe155c4

Comment 17

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (65.0b12 Build ID - 20190117232427) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now a telemetry ping is sent if the "Stage 1" button or the "Dismiss" buttons are clicked.