1515048 - Disable the Payment Request UI and tests by default on Nightly

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

The path to shipping the PaymentRequest UI is still being determined so we should disable the UI by default. We will also disable the tests to reduce the short-term maintenance cost (e.g. intermittent test failure fixes) of the component.

Comment 1

[Matthew N. [:MattN]]

I will leave enabling/disabling the DOM code to the DOM team.

Marcos, do you need to give a heads up to anyone at the W3C before I land this? Since the DOM code and pref to enable the UI will still be available, it will still be possible to test our implementation.

Comment 2

[Marcos Caceres [:marcosc]]

I’m meeting with Ian from W3C in a few hours. Please go ahead and disable.

Comment 3

[Matthew N. [:MattN]]

Cindy, can you check with Nick to see if it's fine to disable-by-default (currently it's enabled on MacOS/Windows in Nightly)? We don't want this to have a negative impact on partner discussions.

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1515048 - Disable the Payment Request UI and tests by default on Nightly. r=baku,jaws

Comment 5

[chsiang]

Hi Matt,
As long as we can flip the pref to turn it on for testing purposes. I don't see there's a problem turning it off by default.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ee226bda683
Disable the Payment Request UI and tests by default on Nightly. r=jaws,baku

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3ee226bda683

Comment 8

[Matthew N. [:MattN]]

Attachment: Bug 1330228 - Test input.hasBeenTypePassword. r=baku,smaug

Depends on D15145

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 66.0a1 (2018-12-20) on Windows 10 x 64 and Mac OS X 10.13.

Comment 10

[Eric Shepherd [:sheppy]]

This is something that needs a quick documentation checkup...

Comment 11

[Eric Shepherd [:sheppy]]

I've tweaked the text in the https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features to note that the UI is not currently working after breaking sometime after the tests were disabled.

Comment 12

[Marcos Caceres [:marcosc]]

Thanks :sheppy.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

:mattn, this has been disabled for 4 months- should we delete the tests? For example the tests pass 10/10 times for windows 10 opt/debug +- qr. Is this worth reenabling?

Comment 14

[Matthew N. [:MattN]]

This bug is about the feature AND tests. My understanding is that the project may be un-pausing "soon". The plan was to wait until end of Q2 to delete if there is no plan to re-enable.

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

so if the tests pass, there is no need to run them now; but assuming we fix this feature, the tests will be useful again.

Comment 16

[Matthew N. [:MattN]]

Yes, we don't want to deal with intermittent (or really any) failures while nobody is working on this feature since it's not shipping code. The front-end doesn't even build outside of Nightly.