1515058 - Make the taskgraph sparse-profile include the docker-image sparse-profile

Status: REOPENED

(Firefox Build System :: Task Configuration, task, P5)

Description

[Kartikaya Gupta (email:[e-mail])]

Spinoff from https://phabricator.services.mozilla.com/D14405#inline-79591

Right now if you add a new docker image with some external script dependency, you also need to add that script to the taskgraph sparse-profile file at [1], because the taskgraph needs to know if the script has changed in order to decide whether or not to rebuild the docker image. Manually listing the file here seems redundant in that the taskgraph profile could just include the docker-image profile which should have those files listed already.

[1] https://searchfox.org/mozilla-central/source/build/sparse-profiles/taskgraph

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I looked through the list and right now all the files included in the docker-image profile are included as part of globs or subfolders of other entries in the taskgraph profile. So doing this won't actually remove any existing entries from sparse-profiles/taskgraph, although it would prevent my new entry from bug 1507884.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

So I just updated the patch in bug 1507884 to do it.

Comment 3

[Mike Hommey [:glandium]]

My guess is that those globs could be removed. I think it's still worth having this bug open to remove them.