15151 - Client Edge may be wrong for top-level windows

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Michael Lowe]

Rod,

Don't know if you are right person for this, but top level windows currently
have a client edge style.    They should really be changed to non-client windows
by adding the following style:  WS_EX_WINDOWEDGE (I think - haven't tested it
so no guarantees)

This would allow the XUL chrome to merge into the edge of the native window
instead of seeming sunk beneath it.

Comment 1

[rods (gone)]

added summary

Comment 2

[rods (gone)]

I am not sure I understand what exactly neto be fixed. When a window is created
that is a popup its styles are set to:

extendedStyle = WS_EX_TOPMOST;
style = WS_POPUP;

Which means WS_EX_WINDOWEDGE is not set, in fact I unset WS_EX_WINDOWEDGE and
nothing seemed to change.

Could you explain more? Thanks.

Comment 3

[Michael Lowe]

Attachment: Screenshot

Comment 4

[Michael Lowe]

Ok, by top level windows I actually mean the main browser/mailnews/editor
windows.   After comparing the window styles of these windows with those from
4.x I see that the main difference is that WS_EX_WINDOWEDGE is not set, which
probably leads to the sunken look I mentioned previously (and should be visible
in the attached screenshot).   I don't have the time to mess around with the
code at present, but hopefully you or someone else could have a look at this and
see what they can come up with.   It is just a minor visual problem, but it has
been annoying me for some time.

Comment 5

[rods (gone)]

Kevin, could you take a look at this since you were recently working nsWindow
with some of these flags?

Comment 6

[Kevin McCluskey (gone)]

Changing to WS_EX_WINDOWEDGE.

Comment 7

[Kevin McCluskey (gone)]

Fixed in Oct 11, 1999 5:17PM build.