Closed Bug 1515104 Opened 5 years ago Closed 5 years ago

Spinbutons in preferences too wide

Categories

(Thunderbird :: Theme, enhancement)

Product:
Thunderbird
Component:
Theme
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird65 fixed, thunderbird66 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0
Tracking Flags:
Tracking Status
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

1515104-spinbutton-width.patch
1.73 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
Since bug 1511394 are the spinbuttons too wide.
The buttons are still a bit wide, but fits to the other buttons with the same paddings and makes them easier clickable. Mac needs a bit different fix like it also differes in bug 1513181.

Spinbuttons are in "Customize New Mail Alert" or in Calendar tab.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9032192 - Flags: review?(jorgk)
Comment on attachment 9032192 [details] [diff] [review]
1515104-spinbutton-width.patch

Yes, they look better on Windows now. I can't test the Mac part (as you know).
Attachment #9032192 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0de1fa19a420
Fix the preferences spinbutton width after bug 1511394. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
Comment on attachment 9032192 [details] [diff] [review]
1515104-spinbutton-width.patch

If it's caused by bug 1511394 it will need uplift, right?
Attachment #9032192 - Flags: approval-comm-beta+
Yes, uplift is good.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: