1515105 - ./mach try syntax should turn off git's commit.gpgsign option

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, enhancement, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

When I use "./mach try syntax ..." in a git-cinnabar tree, I get prompted for my GPG passphrase, since my ~/.gitconfig has:

[commit]
        gpgSign = true

It seems like passing "-c commit.gpgsign=false" would avoid this, and I think mach try syntax probably ought to do this when making the temporary commit.

(It's not clear to me whether the canonical name for this configuration parameter has a capital "s" in it; https://help.github.com/articles/signing-commits/ seems to use lowercase as do lots of other articles, but my configuration has capital for some reason, perhaps historical...)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(The same issue exists with "./mach try chooser".)

Comment 2

[Andrew Halberstadt [:ahal]]

Just noting this config can be added here:
https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/python/mozversioncontrol/mozversioncontrol/__init__.py#457

It'll apply to all mach try selectors (including syntax, chooser and fuzzy).

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I just did a try push successfully with the patch, and it didn't prompt me for my GPG passphrase to sign the temporary commit.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Bug 1515105 - Turn off git commit.gpgSign when making temporary commits for try pushes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1c8bd117233
Turn off git commit.gpgSign when making temporary commits for try pushes. r=ahal

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Bug 1515105 - Adjust test for turning off git commit.gpgSign when making temporary commits for try pushes. r?ahal

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b1c8bd117233

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7a2d32cfb3e
Adjust test for turning off git commit.gpgSign when making temporary commits for try pushes.  r=ahal

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d7a2d32cfb3e