Closed Bug 1515105 Opened 11 months ago Closed 5 months ago

./mach try syntax should turn off git's commit.gpgsign option

Categories

(Firefox Build System :: Try, enhancement, P3)

enhancement

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: dbaron, Assigned: dbaron, Mentored)

References

Details

Attachments

(2 files)

When I use "./mach try syntax ..." in a git-cinnabar tree, I get prompted for my GPG passphrase, since my ~/.gitconfig has:

[commit]
        gpgSign = true

It seems like passing "-c commit.gpgsign=false" would avoid this, and I think mach try syntax probably ought to do this when making the temporary commit.

(It's not clear to me whether the canonical name for this configuration parameter has a capital "s" in it; https://help.github.com/articles/signing-commits/ seems to use lowercase as do lots of other articles, but my configuration has capital for some reason, perhaps historical...)
Summary: ./mach try syntax should turn off git's commit.gpgSign option → ./mach try syntax should turn off git's commit.gpgsign option
Priority: -- → P3

(The same issue exists with "./mach try chooser".)

Just noting this config can be added here:
https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/python/mozversioncontrol/mozversioncontrol/__init__.py#457

It'll apply to all mach try selectors (including syntax, chooser and fuzzy).

Mentor: ahal
Keywords: good-first-bug
Assignee: nobody → dbaron
Keywords: good-first-bug

I just did a try push successfully with the patch, and it didn't prompt me for my GPG passphrase to sign the temporary commit.

Pushed by dbaron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1c8bd117233
Turn off git commit.gpgSign when making temporary commits for try pushes. r=ahal
Regressions: 1561457
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Pushed by dbaron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7a2d32cfb3e
Adjust test for turning off git commit.gpgSign when making temporary commits for try pushes.  r=ahal
You need to log in before you can comment on or make changes to this bug.