Closed
Bug 1515105
Opened 5 years ago
Closed 5 years ago
./mach try syntax should turn off git's commit.gpgsign option
Categories
(Developer Infrastructure :: Try, enhancement, P3)
Developer Infrastructure
Try
Tracking
(firefox69 fixed)
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: dbaron, Assigned: dbaron, Mentored)
References
Details
Attachments
(2 files)
When I use "./mach try syntax ..." in a git-cinnabar tree, I get prompted for my GPG passphrase, since my ~/.gitconfig has: [commit] gpgSign = true It seems like passing "-c commit.gpgsign=false" would avoid this, and I think mach try syntax probably ought to do this when making the temporary commit. (It's not clear to me whether the canonical name for this configuration parameter has a capital "s" in it; https://help.github.com/articles/signing-commits/ seems to use lowercase as do lots of other articles, but my configuration has capital for some reason, perhaps historical...)
Assignee | ||
Updated•5 years ago
|
Summary: ./mach try syntax should turn off git's commit.gpgSign option → ./mach try syntax should turn off git's commit.gpgsign option
Updated•5 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•5 years ago
|
||
(The same issue exists with "./mach try chooser".)
Comment 2•5 years ago
•
|
||
Just noting this config can be added here:
https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/python/mozversioncontrol/mozversioncontrol/__init__.py#457
It'll apply to all mach try
selectors (including syntax, chooser and fuzzy).
Mentor: ahal
Keywords: good-first-bug
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → dbaron
Keywords: good-first-bug
Assignee | ||
Comment 3•5 years ago
|
||
I just did a try push successfully with the patch, and it didn't prompt me for my GPG passphrase to sign the temporary commit.
Assignee | ||
Comment 4•5 years ago
|
||
Pushed by dbaron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1c8bd117233 Turn off git commit.gpgSign when making temporary commits for try pushes. r=ahal
Assignee | ||
Comment 6•5 years ago
|
||
Comment 7•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Pushed by dbaron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d7a2d32cfb3e Adjust test for turning off git commit.gpgSign when making temporary commits for try pushes. r=ahal
Comment 9•5 years ago
|
||
bugherder |
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•