1515151 - Smartcard label not displayed in security module dialog (only reader name) whereas smartcard is actually inserted

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Description

[BPER_ILEX]

Attachment: Smartcard_label_not_shown_FF64_01.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

load pkcs#11 module via webextension
insert smartcard
go to security module dialog
in the left panel, the reader name is shown


Actual results:

go to security module dialog
in the left panel, the reader name is shown under module name


Expected results:

the smart card label should have been displayed instead (this was the case in FF 61.0.2)

Comment 1

[BPER_ILEX]

Normally, the reader name is displayed when no smartcard is detected in device.

Comment 2

[BPER_ILEX]

Attachment: Smartcard_Label_on_FF61.0.2_Device_Manager.PNG

Comment 3

[BPER_ILEX]

Actually the diplay change occurs in FF 62.0

Comment 4

[Johann Hofmann [:johannh]]

It might be helpful to find out how and why this changed. Can you do a run with mozregression (https://mozilla.github.io/mozregression/) to find the commit that broke this for you? Thanks!

Comment 5

[BPER_ILEX]

Attachment: the regression seems to appear between nigthlies 2018-06-04 & 2018-06-05

Comment 6

[BPER_ILEX]

Attachment: Detailed mozregression results in a file

Comment 7

[Johann Hofmann [:johannh]]

Seems like bug 1465976, then. Dana, can you take a look at this, please? Thank you!

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

That change was deliberate. We now list slot names under each module to be consistent (since a token might not be present in the slot). In the details pane, you can see the token's name if it is present. Bertrand, is there a particular concern you have with the UI behaving this way?

Comment 9

[BPER_ILEX]

Hello Dana,

It's only a visual commodity suggestion for end users.

Now, when i open 'device manager',
only slot names are listed in the modules pane.

With the old way,
you could see at first sight when opening DM, if a token was recognized by showing its label.

with the new design, you have to click all listed slots to see if there is an actual token in the detail pane.
I don't find it practical.

The very first time I saw this, I believed that our custom pkcs#11 was not working with ff62 because I was accustomed to the old display!
Then I had to click the slotname to realize that the token was present.

Isn't possible to restore the old way by a setting in about:config for example ?

Comment 10

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

No - it would be more work than it's worth to support making this configurable. I realize it's more work, but you'll just have to click one more time if you want to see if the token is present.