1515154 - try submission emails from Taskcluster have broken URL in the text/plain half

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

When I submit a try push, I get a multipart/alternative email that has both a text/plain and text/html part.  I think in some way what generates the email starts with this code:

https://searchfox.org/mozilla-central/rev/13788edbabb04d004e4a1ceff41d4de68a8320a2/.taskcluster.yml#243-248

The link to treeherder in the text/html half of the multipart/alternative email works fine.  However, in the text/plain part of the multipart/alternative email, the body of the message looks like this:

=====
Your try push has been submitted. It's the best! Use the link to view the status of your
jobs.Treeherder Jobs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7e26c72d07a1a829de9db6096fdef51cc4aa733
email rate limit remaining: 50
Mozilla Taskcluster | docs.taskcluster.net | irc.mozilla.org#taskcluster
=====

This link doesn't work because it uses HTML escaping "&" instead of just using "&".  This escaping is correct in the text/html half of the email, but breaks the link in the plaintext half.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-notify/pull/48