Status

()

enhancement
P2
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(5 attachments)

Assignee

Description

5 months ago
The upcoming changes remove unused fields, rearrange fields for better packing,
and de-aggregate nsLoadGroup, all in the name of making it smaller.
Assignee

Comment 1

5 months ago
This was in my patch stack for test purposes, but later patches wind up
removing the assert.  I'm happy to fold it away if you like.
Attachment #9032275 - Flags: review?(valentin.gosu)
Assignee

Comment 2

5 months ago
We only write to this variable and never read it.  The whole
nsPILoadGroupInternal interface looks like it could go away, actually;
we'll do that in a subsequent patch.
Attachment #9032276 - Flags: review?(valentin.gosu)
Assignee

Comment 3

5 months ago
We apparently had this for internal extension hooks that couldn't be
depended on externally...but now that interfaces aren't exposed to
addons, we can remove this no-op interface entirely.
Attachment #9032277 - Flags: review?(valentin.gosu)
Assignee

Comment 4

5 months ago
Due to member alignment rules on 64-bit platforms, nsLoadGroup has more
unused space than it should.  Shuffling members around a little to fill
in holes should make nsLoadGroup somewhat smaller.
Attachment #9032278 - Flags: review?(valentin.gosu)
Assignee

Comment 5

5 months ago
We no longer use the aggregation facility for nsLoadGroup, and removing
it saves approximately 10% of the space consumed by nsLoadGroup.
Attachment #9032279 - Flags: review?(valentin.gosu)
Assignee

Updated

5 months ago
Blocks: 1514936
Attachment #9032275 - Flags: review?(valentin.gosu) → review+
Attachment #9032276 - Flags: review?(valentin.gosu) → review+
Attachment #9032277 - Flags: review?(valentin.gosu) → review+
Attachment #9032278 - Flags: review?(valentin.gosu) → review+
Attachment #9032279 - Flags: review?(valentin.gosu) → review+
Priority: -- → P2
Whiteboard: [necko-triaged]
Assignee

Comment 6

5 months ago
Worth noting that we have a clean try run (well, modulo a few HTTP 500 errors) with the release assert in place:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d34d7ee014cf578287e6c60e7dd03ec23aaf242

I think I am just going to drop that first part.

Comment 7

5 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83a64c5eb4fc
part 1 - remove nsLoadGroup::mTimedNonCachedRequestsUntilOnEndPageLoad; r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/7caeaeed08f0
part 2 - remove nsPILoadGroupInternal; r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c961fec66d8
part 3 - pack holes in nsLoadGroup better on 64-bit platforms; r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a00beb701e
part 4 - un-aggregate nsLoadGroup; r=valentin
You need to log in before you can comment on or make changes to this bug.