Consider removing the window length setting from the perf panel

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: mstange, Assigned: canaltinova)

Tracking

unspecified
Firefox 66

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 months ago
The performance panel is not designed for a continuous profiling workflow. It's designed for the "start profiling, do something, stop profiling" workflow.

However, currently we also have a setting for the fixed time window length in the panel, and it defaults to 20 seconds. I think we should consider removing this setting, or at least initializing it with "infinity", so that we don't accidentally cut off people's recordings.

The fixed time window setting is really only intended for the "continuous profiling" workflow. The few people that use this workflow use it through the Gecko Profiler add-on, not through the devtools performance panel.
I'm fine defaulting to Infinity for this, the reasoning makes sense to me. Nazim, what do you think?

Aaaaah we spent so much time polishing the actor/client mechanism to do this properly :-)
Flags: needinfo?(canaltinova)
Priority: -- → P2
(Assignee)

Comment 2

5 months ago
Yeah, it also makes sense to me. I can make it default to Infinity and remove the setting from panel.

Heh, yeah it took a while to make actor/client mechanishm :)
Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
Flags: needinfo?(canaltinova)
(Assignee)

Comment 4

5 months ago
We made the profiler buffer resizable before that patch but then we decided that
it's not a good idea to do since we are spending so much time to allocate memory.
Since buffer size is constant, we don't need to add "max" anymore.

Depends on D15655

Comment 6

4 months ago
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/27dc3484e7ef
Remove the window length setting from devtools performance panel r=julienw
https://hg.mozilla.org/integration/autoland/rev/f46ff2feaf5f
Remove the "max" from "Max buffer size" label since it's not resizable anymore r=julienw

Comment 7

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.