Closed Bug 1515209 Opened 2 years ago Closed 2 years ago

Add markers for <script> execution

Categories

(Core :: Gecko Profiler, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(2 files)

We have a profiling label for <script> execution in ScriptLoader::ProcessScriptElement or in ScriptLoader::EvaluateScript. We should add profiler markers for these as well, so that it's easier to compare them at a glance from the marker chart.

I'm changing the profiler label in bug 1514007, so any work in this bug should probably based on that bug.
Priority: -- → P3
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/2250278e1466
Add profiler_add_text_marker and AUTO_PROFILER_TEXT_MARKER_DOCSHELL for convenience, and add the ability to specify cause stacks. r=gerald
https://hg.mozilla.org/integration/autoland/rev/1d6f26a48a9a
Add a text marker for <script> evaluation. r=gerald
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Hi Markus, I noticed bug 1514007 affects 66. Is this something you're intending to uplift to beta 66?

Flags: needinfo?(mstange)

I'm not intending to uplift this to 66.

Flags: needinfo?(mstange)

Thanks! I love to hear that right about now in beta :)

Depends on: 1529480
You need to log in before you can comment on or make changes to this bug.