1515209 - Add markers for <script> execution

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Markus Stange [:mstange]]

We have a profiling label for <script> execution in ScriptLoader::ProcessScriptElement or in ScriptLoader::EvaluateScript. We should add profiler markers for these as well, so that it's easier to compare them at a glance from the marker chart.

I'm changing the profiler label in bug 1514007, so any work in this bug should probably based on that bug.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1515209 - Add profiler_add_text_marker and AUTO_PROFILER_TEXT_MARKER_DOCSHELL for convenience, and add the ability to specify cause stacks. r?jesup

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1515209 - Add a text marker for <script> evaluation. r?jesup

Depends on D19188

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2250278e1466
Add profiler_add_text_marker and AUTO_PROFILER_TEXT_MARKER_DOCSHELL for convenience, and add the ability to specify cause stacks. r=gerald
https://hg.mozilla.org/integration/autoland/rev/1d6f26a48a9a
Add a text marker for <script> evaluation. r=gerald

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2250278e1466
https://hg.mozilla.org/mozilla-central/rev/1d6f26a48a9a

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Hi Markus, I noticed bug 1514007 affects 66. Is this something you're intending to uplift to beta 66?

Comment 6

[Markus Stange [:mstange]]

I'm not intending to uplift this to 66.

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Thanks! I love to hear that right about now in beta :)