Reporting API depends on notifications used by old localStorage implementation

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: janv, Assigned: baku)

Tracking

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

6 months ago
Reporting API uses browser:purge-domain-data and extension:purge-localStorage notifications to clear internal data. However these notifications were originally intended for localStorage only, I think.

New localStorage implementation got rid of these notifications, but I had to add them back since Reporting API landed in the meantime which obviously depends on them.

See also bug 1513850 comment 4.

Hey :baku,

I know you worked on this and also have knowledge of storage. What is the priority for this?

Thanks

Flags: needinfo?(amarchesini)
Assignee

Updated

6 months ago
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Assignee

Comment 2

6 months ago
Posted patch report.patch (obsolete) — Splinter Review
Attachment #9035625 - Flags: review?(jkt)
Assignee

Comment 3

6 months ago
Posted patch report.patchSplinter Review
Attachment #9035625 - Attachment is obsolete: true
Attachment #9035625 - Flags: review?(jkt)
Attachment #9035635 - Flags: review?(jkt)

Comment on attachment 9035635 [details] [diff] [review]
report.patch

r+ from me however please also get someone else who knows this code more janv, smaug or asuth perhaps?

Attachment #9035635 - Flags: review?(jkt) → review+
Assignee

Updated

6 months ago
Attachment #9035635 - Flags: review?(bugs)

Updated

6 months ago
Attachment #9035635 - Flags: review?(bugs) → review+

Comment 5

6 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58fad84cc31a
Separate ClearData flag for Reporting data, r=jkt, r=smaug

Comment 6

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.