Closed Bug 1515277 Opened 2 years ago Closed 2 years ago

Reporting API depends on notifications used by old localStorage implementation

Categories

(Core :: DOM: Security, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: janv, Assigned: baku)

Details

Attachments

(1 file, 1 obsolete file)

Reporting API uses browser:purge-domain-data and extension:purge-localStorage notifications to clear internal data. However these notifications were originally intended for localStorage only, I think.

New localStorage implementation got rid of these notifications, but I had to add them back since Reporting API landed in the meantime which obviously depends on them.

See also bug 1513850 comment 4.

Hey :baku,

I know you worked on this and also have knowledge of storage. What is the priority for this?

Thanks

Flags: needinfo?(amarchesini)
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attached patch report.patch (obsolete) — Splinter Review
Attachment #9035625 - Flags: review?(jkt)
Attached patch report.patchSplinter Review
Attachment #9035625 - Attachment is obsolete: true
Attachment #9035625 - Flags: review?(jkt)
Attachment #9035635 - Flags: review?(jkt)

Comment on attachment 9035635 [details] [diff] [review]
report.patch

r+ from me however please also get someone else who knows this code more janv, smaug or asuth perhaps?

Attachment #9035635 - Flags: review?(jkt) → review+
Attachment #9035635 - Flags: review?(bugs)
Attachment #9035635 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58fad84cc31a
Separate ClearData flag for Reporting data, r=jkt, r=smaug
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.