151529 - No list of votes shown if there is a plus sign (+) in the address

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[zug_treno]

If you want to see all votes of somebody with a + sign in his/her e-mail
address, it will show an errormessage about it not being a valid username.

How to reproduce: 
1. Go to a bug with a lot of voters (i.e. bug 22687). 
2. Click on show votes for this bug.
3. Find a random voter with a + in his/her e-mail address. 
4. Click on the address to see his/her other votes.

Result: an error message.
Expected: a list with votes.

Using %2b instead of + will return the correct result.

Comment 1

[Bradley Baetz (:bbaetz)]

We need to 'FILTER url FILTER html' the email address

Note that the + in the username answers the question of whether email addresses
need uri escaping as well as html escaping - they do.

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: v1

Sigh. We actually need url_quote, because + is valid in a uri...
We can't use this for linkification, because then the @ is escaped, which isn't
what we want. Sigh. mozmail seems happy with taking 'mailto:foo+bar@localhost',
and not converting the + to a space. Lets leave that part, I think.

Comment 3

[Bradley Baetz (:bbaetz)]

-> me

Comment 4

[Jouni Heikniemi]

Is there a reason to use the pipe syntax here, when all the other templates use
"FILTER"?

Comment 5

[Bradley Baetz (:bbaetz)]

I prefer | - its shorter + simpler

Most use FILTER because ISTR | is a newer addition, and at the time we didn't
require that new version of TT. I'm not sure about that, though.

Comment 6

[Jouni Heikniemi]

Gerv, Myk, Dave cc'd for comments.

| or FILTER, then? I prefer FILTER because of its readability. | is more
Perlish, though. Anyway, I don't think it's a good idea to mix them; we should
pick one and stick with it. 

My vote goes for consistent use of FILTER, not the least because we've just
implemented a load of templates with that.

Comment 7

[Bradley Baetz (:bbaetz)]

Attachment: v2

Fine. Also, we don't need to html escape after url quoting, because url quoting
converts non-alphanum, _, - and . to %XX form anyway.

Comment 8

[Matthew Tuck [:CodeMachine]]

Shouldn't you whack all the instances of not filtering email addresses while
you're at it?

Comment 9

[Bradley Baetz (:bbaetz)]

No, this doesn't affect display, the issue here is that + is 'special' wrt a
uri. See comment 2 on why we can't use this for linkifying mailto stuff.

Comment 10

[Jouni Heikniemi]

Comment on attachment 87772 [details] [diff] [review]
v2

2xr=jouni

Comment 11

[Bradley Baetz (:bbaetz)]

Checked in, trunk + branch