Closed
Bug 1515345
Opened 5 years ago
Closed 5 years ago
We should not show the notification bar when multiple filePickers are blocked
Categories
(Toolkit Graveyard :: Notifications and Alerts, enhancement)
Toolkit Graveyard
Notifications and Alerts
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
1.37 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently, when multiple filePickers are opened simultaneously, we allow the first one and we block the others using the popup-blocker algorithm. We also show the notification bar to inform the user about the blocking. The notification bar is confusing for filePicker blocking and we should not show any notification.
|
Assignee | |
Comment 1•5 years ago
|
||
Assignee: nobody → amarchesini
Attachment #9032441 -
Flags: review?(bugs)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9032441 [details] [diff] [review] a.patch So this explicitly regresses https://bugzilla.mozilla.org/show_bug.cgi?id=36619#c105 But looks like others don't show the warning.
Attachment #9032441 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ac619ffc36b7 No notification bar when filePickers are blocked, r=smaug
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ac619ffc36b7
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Updated•10 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•