Closed Bug 1515356 Opened 10 months ago Closed 9 months ago

implicitly-declared 'IPC::Principal::Principal(const IPC::Principal&)' is deprecated [-Werror=deprecated-copy]

Categories

(Firefox Build System :: Source Code Analysis, defect, P3)

defect

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In file included from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/dom/PContentChild.h:9,
                  from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/ContentChild.h:15,
                  from /root/firefox-gcc-last/security/manager/ssl/nsKeygenHandlerContent.cpp:13,
                  from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/security/manager/ssl/Unified_cpp_security_manager_ssl1.cpp:92:
 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/dom/PContent.h: In constructor 'mozilla::dom::BlobURLRegistrationData::BlobURLRegistrationData(const nsCString&, const IPCBlob&, const Principal&, const bool&)':
 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/dom/PContent.h:2716:26: error: implicitly-declared 'IPC::Principal::Principal(const IPC::Principal&)' is deprecated [-Werror=deprecated-copy]
  2716 |         revoked_(_revoked)

We have a bunch of others
Here is how llvm/clang review to fix their C++ (building with gcc)
https://reviews.llvm.org/D52863 - LLVM cleanup
https://reviews.llvm.org/D52864 - Clang cleanup
I can't see what the warning is really complaining about, nor why the proposed fixes make any difference other than making the warning go away.  What is the actual point of the warning?  Something related to base classes?
Flags: needinfo?(sledru)
Honestly, I just did a brute force to see what kind of warnings it is finding (bug 1514781)
I didn't look if they are relevant or not.
Flags: needinfo?(sledru)
Duplicate of this bug: 1517230
Just as Nathan said, if something that is not very obvious I'm missing I don't understand why is this useful in this context. Looking other the LLVM fixes these are only relevant when the copy constructor implementation is the same as a default implementation, but even so this doesn't bring something very useful to our code, maybe it's more obvious the initial intent of the developer having something 'default' and not 'custom 'implemented.
My take on this is that we should close it.
Priority: -- → P3
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1472d595d0a7
Do not fail the build in case of warning with -Wdeprecated-copy r=froydnj
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → sledru
You need to log in before you can comment on or make changes to this bug.