Closed Bug 1515376 Opened 9 months ago Closed 9 months ago

remove aggregation support from nsProperties

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This support is currently unused.
Attachment #9032447 - Flags: review?(continuation)
Blocks: 1514936
Comment on attachment 9032447 [details] [diff] [review]
remove aggregation support from nsProperties

Review of attachment 9032447 [details] [diff] [review]:
-----------------------------------------------------------------

Yay. nsAgg.h is a persistent grain of sand in my shoe when I work on the cycle collector, so it is good to see it getting phased out.

::: xpcom/ds/nsProperties.h
@@ +21,3 @@
>    NS_DECL_NSIPROPERTIES
>  
> +  nsProperties() {}

= default instead?
Attachment #9032447 - Flags: review?(continuation) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3106fe4aaaa3
remove aggregation support from nsProperties; r=mccr8
https://hg.mozilla.org/mozilla-central/rev/3106fe4aaaa3
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.