Closed Bug 1515379 Opened 11 months ago Closed 11 months ago

mFramesDeliveredToEncoder stat is should be initialized in VideoConduit

Categories

(Core :: WebRTC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- wontfix
firefox65 --- fixed
firefox66 --- fixed

People

(Reporter: ng, Assigned: ng)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is causing us to report a wildly high. This field used to be a type that had a default initializer.
This initializes a one of the stats that lost its default initialization when it was changed from an Atomic to a plain old int.
(In reply to Nico Grunbaum [:ng] from comment #0)
> This is causing us to report a wildly high. This field used to be a type
> that had a default initializer.

This is causing us to report a wildly high **dropped frames**. This should be easy to uplift once it has sat on nightly for a day.
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/a80057e6229d
initialize frames delivered stat and add test r=dminor
https://hg.mozilla.org/mozilla-central/rev/a80057e6229d
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Flags: in-testsuite+
Please nominate this for Beta approval when you get a chance.
Flags: needinfo?(na-g)
Comment on attachment 9032452 [details]
Bug 1515379 - initialize frames delivered stat and add test

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1404992

User impact if declined: WebRTC implementing websites will not have accurate information about degraded calls.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Tiny patch which ensures that a statistic is properly initialized.

String changes made/needed: none
Flags: needinfo?(na-g)
Attachment #9032452 - Flags: approval-mozilla-beta?
Comment on attachment 9032452 [details]
Bug 1515379 - initialize frames delivered stat and add test

[Triage Comment]
Improves information about degraded calls for websites using WebRTC. Approved for 65.0b7.
Attachment #9032452 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.