Closed Bug 1515392 Opened 5 years ago Closed 5 years ago

Non-blank paint detection incorrectly detects blank paints as non-blank

Categories

(Core :: Web Painting, enhancement, P2)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1514651
Tracking Status
firefox66 --- affected

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

The detection currently ignores SOLID_COLOR items from the canvas frame, but not from the viewport frame. But ever since bug 1349418, we have a SOLID_COLOR item behind the page for the viewport frame, so we incorrectly detect every paint as non-blank.
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/538c59c855db
Ignore the viewport background color for the purposes of detecting non-blank paints. r=mattwoodrow
Priority: -- → P2

From the log at https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218015160&repo=autoland&lineNumber=753 :

Cycle 1(1): loaded about:preferences (next: about:blank)
fnbpaint is not yet available (0), retry number 1...
...
unable to get a value for fnbpaint after 11 retries
Abort: firstNonBlankPaint value is not available after loading the page

Flags: needinfo?(mstange)

Fixing this bug no longer seems worth it. Non-blank paint is not a very useful metric; we now have FirstContentfulPaint which is better. I'm going to dupe this bug forward to bug 1514651, which is about removing the Non-blank paint code.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: