1515475 - JS_SetGCParametersBasedOnAvailableMemory / JSGCConfig has 13 elements, not 14

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Gabriel Russell]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Steps to reproduce:

https://github.com/mozilla/gecko-dev/blob/master/js/src/jsapi.cpp#L1286



Actual results:

static const size_t NumGCConfigs = 14;

is wrong. those JSGCConfig arrays have 13 elements.

JS_SetGCParameter(cx, config[i].key, config[i].value);

executes JS_SetGCParameter for config[13] which doesn't exist

In prior versions the arrays had 14 elements. At some point, one of them was taken out, but the count was not updated.

https://github.com/mozilla/gecko-dev/commit/2d06bc1282227aad9ce5a2c22d3aaeb4418bb37b


Expected results:

static const size_t NumGCConfigs = 13;

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1515475-gc-configs

Refactor JS_SetGCParametersBasedOnAvailableMemory to use C++ ranged for loop which will use array length from the type and remove use of incorrect hardcoded array length.

Comment 2

[Paul Bone [:pbone]]

Comment on attachment 9034187 [details] [diff] [review]
bug1515475-gc-configs

Review of attachment 9034187 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Paul Bone [:pbone]]

Thanks for noticing this Gabriel.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da05e40ae372
Remove hardcoded length of config arrays for JS_SetGCParametersBasedOnAvailableMemory a=pbone

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/da05e40ae372