Closed Bug 1515504 Opened Last year Closed Last year
Thunderbird builds getting incorrect MOZ
_APP _VERSION _DISPLAY value
47 bytes, text/x-phabricator-request
|Details | Review|
Recent Thunderbird builds (65.0b1) have been reporting the Firefox version (65.0b5) in places like "about:". With assistance from [:glandium], the problem was tracked down to moz.configure trying to read version.txt and version_display.txt from an incorrect path. (build/moz.configure/init.configure:1089) This is currently blocking the release of TB 65.0b1.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
(In reply to Rob Lemley [:rjl] from comment #2) > Created attachment 9032568 [details] [diff] [review] > Fi x path to version.txt for subprojecfts > > Try build at > https://treeherder.mozilla.org/#/jobs?repo=try-comm- > central&revision=6bab949961d84eb4e75ae357bf8338fd4372997d Rather: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fcdfa7a6e0cff276b07ce829c07817663884094c
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/06c4580d6f43 Fix the path we check version.txt/version_display.txt under in non-browser projects. r=nalexander
Could we get beta approval for this to go ahead with our TB 65 beta build. Who can approve?
Comment on attachment 9032566 [details] Bug 1515504 - Fix the path we check version.txt/version_display.txt under in non-browser projects. [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1502457 User impact if declined: Thunderbird and Seamonkey don't get the right version number displayed Is this code covered by automated tests?: No Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): It's a no-op for Firefox. String changes made/needed: N/A
Attachment #9032566 - Flags: approval-mozilla-beta?
Thanks Mike. Isn't there a "shortcut" for build/release stuff approvals? Aki was kind enough to uplift something for us right away in bug 1508056. Sorry, I'd like to avoid having to take this onto a branch and I'd like to build TB 65 before Christmas.
Comment on attachment 9032566 [details] Bug 1515504 - Fix the path we check version.txt/version_display.txt under in non-browser projects. [Triage Comment] Fixes incorrect MOZ_APP_VERSION for non-Firefox apps. NPOTB for Firefox. Approved for 65.0b7.
Attachment #9032566 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.