1515558 - Crash in nsPresContext::CacheAllLangs

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This bug was filed from the Socorro interface and is
report bp-26a01bdf-3169-4280-a42f-e68d10181219.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so nsPresContext::CacheAllLangs layout/base/nsPresContext.cpp:1882
1 libxul.so mozilla::ServoStyleSet::PreTraverse layout/style/ServoStyleSet.cpp:445
2 libxul.so mozilla::ServoStyleSet::StyleDocument layout/style/ServoStyleSet.cpp:971
3 libxul.so mozilla::RestyleManager::DoProcessPendingRestyles layout/base/RestyleManager.cpp:3024
4 libxul.so mozilla::PresShell::DoFlushPendingNotifications layout/base/PresShell.cpp:4326
5 libxul.so mozilla::dom::Selection::Stringify dom/base/Selection.cpp:420
6 libxul.so mozilla::AccessibleCaretManager::DispatchCaretStateChangedEvent layout/base/AccessibleCaretManager.cpp:1422
7 libxul.so mozilla::AccessibleCaretManager::UpdateCaretsForSelectionMode layout/base/AccessibleCaretManager.cpp:368
8 libxul.so mozilla::AccessibleCaretManager::OnReflow layout/base/AccessibleCaretManager.cpp:684
9 libxul.so mozilla::AccessibleCaretEventHub::Reflow layout/base/AccessibleCaretEventHub.cpp:670

=============================================================

Comment 1

[Cameron McCormack (:heycam)]

Is this a dupe of bug 1445794?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yes, though note that I have a patch papering over this (not flushing when the document has already gone to the bfcache) in bug 1514511.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)
> Yes, though note that I have a patch papering over this (not flushing when
> the document has already gone to the bfcache) in bug 1514511.

Emilio, will additional work be needed in this bug after you paper over the crash in bug 1514511? Do you have an estimate of when you will be able to land bug 1514511?

This CacheAllLangs crash signature is Android top crash #2 (in Focus 8.0 testing of GeckoView 64).

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson (:cpeterson) from comment #3)
> This CacheAllLangs crash signature is Android top crash #2 (in Focus 8.0
> testing of GeckoView 64).

Correction: I meant this is top crash #7, not #2.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(In reply to Chris Peterson (:cpeterson) from comment #3)
> Emilio, will additional work be needed in this bug after you paper over the
> crash in bug 1514511?

Nope, though we should probably fix the root cause which is bug 1445794.

> Do you have an estimate of when you will be able to land bug 1514511?

Whenever Boris gets to review the second patch there. Otherwise only the crash with that stuck would get fixed, which is not great.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Whenever Boris gets to review the second patch there.

You mean in bug 1514511? I'm not flagged to review anything there....

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Oh wow, not sure what happened there... Sorry, should've noticed. :(

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I just check the crash report link in comment 0. There are still crash reports coming in as of today, but the version numbers are Firefox 65 or older. I believe the root cause has been addressed in either bug 1514511 or bug 1445794, where both are fixed in Firefox 66.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.