Closed
Bug 1515577
Opened 5 years ago
Closed 5 years ago
Don't quote shell strings when they contain a ~, except in first position
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
We only need to quote strings that would be treated specially by the shell, and "foo~bar" doesn't get any sort of expansion, while "~foo" gets a user expansion, and to avoid that expansion, those latter strings need to be quoted, but not the former.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/6944bc1c900b Don't quote shell strings when they contain a ~, except in first position. r=ted
Comment 3•5 years ago
|
||
Backed out changeset 6944bc1c900b (Bug 1515577) for build bustages on test_checks_configure.py. Backout: https://hg.mozilla.org/integration/autoland/rev/28c8818e06b81f0ee302a6fec2582902bfaa1741 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=6944bc1c900bf512934d145d39475a988ff8eb92&selectedJob=218223911 Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218223911&repo=autoland&lineNumber=47252
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/2cb3a85f0a64 Don't quote shell strings when they contain a ~, except in first position. r=ted
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2cb3a85f0a64
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(mh+mozilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•