Closed Bug 1515579 Opened 10 months ago Closed 9 months ago

Use absolute paths for compilers, etc.

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

No description provided.
Depends on: 1515577
Blocks: 1515528
Depends on: 1515581
Depends on: 1515595
Like for other windows platforms. This currently doesn't make a
difference, but will with next change.
In bug 1259382, some workarounds were added to make the build system
alter PATH and not use absolute paths for toolchain programs, because
autoconf and the build system doesn't deal with spaces in those very
well. But later in bug 1290040, we made find_program return Windows
short paths (without spaces), which alleviates the need for those
workarounds.

We still, however, and unfortunately, need to alter PATH to account for
the fact that MSVC DLLs are not necessarily alongside the compiler
executables...

Depends on D15181
https://hg.mozilla.org/mozilla-central/rev/1d645417b082
https://hg.mozilla.org/mozilla-central/rev/fcf2cca505d4
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Depends on: 1516228
Depends on: 1516090
Depends on: 1516253
Thanks for the backout.
Flags: needinfo?(mh+mozilla)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1519012
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5b112f7e8d9d
Add some mk_export_correct_style to win64-aarch64 mozconfig. r=ted
https://hg.mozilla.org/integration/autoland/rev/fa8e39feef43
Use absolute paths for compilers, etc. r=ted
Status: REOPENED → RESOLVED
Closed: 10 months ago9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.