1515579 - Use absolute paths for compilers, etc.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1515579 - Add some mk_export_correct_style to win64-aarch64 mozconfig.

Like for other windows platforms. This currently doesn't make a
difference, but will with next change.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1515579 - Use absolute paths for compilers, etc.

In bug 1259382, some workarounds were added to make the build system
alter PATH and not use absolute paths for toolchain programs, because
autoconf and the build system doesn't deal with spaces in those very
well. But later in bug 1290040, we made find_program return Windows
short paths (without spaces), which alleviates the need for those
workarounds.

We still, however, and unfortunately, need to alter PATH to account for
the fact that MSVC DLLs are not necessarily alongside the compiler
executables...

Depends on D15181

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1d645417b082
https://hg.mozilla.org/mozilla-central/rev/fcf2cca505d4

Comment 4

[Razvan Maries]

Backed out for causing bugs: 1516228, 1516090, 1516253.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=d30b4fd63e1723d205e31251af32ba8930aa9abd

Backout: https://hg.mozilla.org/mozilla-central/rev/d2bc993e14ea1384c2d9b80cca098b48eb19948a

Comment 5

[Mike Hommey [:glandium]]

Thanks for the backout.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b112f7e8d9d
Add some mk_export_correct_style to win64-aarch64 mozconfig. r=ted
https://hg.mozilla.org/integration/autoland/rev/fa8e39feef43
Use absolute paths for compilers, etc. r=ted

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5b112f7e8d9d
https://hg.mozilla.org/mozilla-central/rev/fa8e39feef43