1515634 - 0.28 - 0.3% installer size (windows2012-32, windows2012-64) regression on push 61ae84746b34535c11ebe99081aafe5e07fb7c91 (Wed Dec 19 2018)

Status: RESOLVED WONTFIX

(Core :: Security, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=61ae84746b34535c11ebe99081aafe5e07fb7c91

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  >200KBytes  installer size windows2012-64 pgo      69,083,665.00 -> 69,288,506.33
  >150KBytes  installer size windows2012-32 pgo      65,738,155.67 -> 65,920,813.92


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=18354

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[Ionuț Goldan [:igoldan]]

This also caused some Talos perf regressions:

== Change summary for alert #18356 (as of Wed, 19 Dec 2018 13:32:28 GMT) ==

Regressions:

  6%  ts_paint_webext windows7-32 opt e10s stylo     332.54 -> 353.00
  6%  ts_paint windows7-32 opt e10s stylo            333.12 -> 353.17

For up to date results, see: http://localhost:5000/perf.html#/alerts?id=18356

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

These are expected regressions and acceptable but we're going to back out for a different reason in Bug 1515631.

Comment 3

[Ionuț Goldan [:igoldan]]

The relanding from https://bugzilla.mozilla.org/show_bug.cgi?id=1485016#c52 brought back the same regressions.
Keeping this bug as WONTFIX.

== Change summary for alert #19169 (as of Tue, 05 Feb 2019 13:58:30 GMT) ==

Regressions:

0% installer size windows2012-64 pgo 69,489,724.92 -> 69,709,843.92
0% installer size windows2012-32 pgo 66,772,482.25 -> 66,974,198.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19169