Closed
Bug 1515646
Opened 5 years ago
Closed 5 years ago
Implement named targetting using BrowsingContext
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: farre, Assigned: farre)
References
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=74ff46ae21342d9813ffc3fea7c6d7b169314d16 Try won't really test that much, that's why I'm only running mochitests, where I've added new tests.
Assignee | ||
Comment 2•5 years ago
|
||
This implements the step of choosing a browsing context with FindWithName, which should be equivalent to calling nsIDocShellTreeItem.findItemWithName passing null for 'aRequestor' and 'aOriginalRequestor' and false for 'aSkipTabGroup'.
Assignee | ||
Comment 3•5 years ago
|
||
Test that BrowsingContext::{FindWithName, FindChildWithName} finds the expected BrowsingContexts and also that BrowsingContext::FindWithName finds the same browsing contexts as if nsIDocShellTreeItem::FindItemWithName had been used. Depends on D15190
Updated•5 years ago
|
Attachment #9032909 -
Attachment description: Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv → Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext.
Updated•5 years ago
|
Attachment #9032910 -
Attachment description: Bug 1515646 - Test BrowsingContext::{FindWithName, FindChildWithName}. r=peterv → Bug 1515646 - Test BrowsingContext::FindWithName.
Updated•5 years ago
|
Fission Milestone: --- → M1
Updated•5 years ago
|
Whiteboard: [1/30] waiting for review
Updated•5 years ago
|
Whiteboard: [1/30] waiting for review → [2/14] revised patches waiting for review
Updated•5 years ago
|
Whiteboard: [2/14] revised patches waiting for review → [2/14] patches r+
Pushed by afarre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9243ddacadcc Add FindWithName and FindChildWithName to BrowsingContext. r=peterv
Pushed by afarre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/996e8765c85a Test BrowsingContext::FindWithName. r=peterv
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9243ddacadcc
https://hg.mozilla.org/mozilla-central/rev/996e8765c85a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Updated•5 years ago
|
Whiteboard: [2/14] patches r+
You need to log in
before you can comment on or make changes to this bug.
Description
•