Implement named targetting using BrowsingContext

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P2
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: farre, Assigned: farre)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Fission Milestone:M1, firefox67 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

5 months ago
No description provided.
Assignee

Updated

5 months ago
Assignee: nobody → afarre
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee

Comment 1

5 months ago
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=74ff46ae21342d9813ffc3fea7c6d7b169314d16

Try won't really test that much, that's why I'm only running mochitests, where I've added new tests.
Assignee

Comment 2

5 months ago
This implements the step of choosing a browsing context with
FindWithName, which should be equivalent to calling
nsIDocShellTreeItem.findItemWithName passing null for 'aRequestor' and
'aOriginalRequestor' and false for 'aSkipTabGroup'.
Assignee

Comment 3

5 months ago
Test that BrowsingContext::{FindWithName, FindChildWithName} finds the
expected BrowsingContexts and also that BrowsingContext::FindWithName
finds the same browsing contexts as if
nsIDocShellTreeItem::FindItemWithName had been used.

Depends on D15190
Attachment #9032909 - Attachment description: Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext. r=peterv → Bug 1515646 - Add FindWithName and FindChildWithName to BrowsingContext.
Attachment #9032910 - Attachment description: Bug 1515646 - Test BrowsingContext::{FindWithName, FindChildWithName}. r=peterv → Bug 1515646 - Test BrowsingContext::FindWithName.

Updated

4 months ago
Fission Milestone: --- → M1

Updated

4 months ago
Whiteboard: [1/30] waiting for review

Updated

3 months ago
Whiteboard: [1/30] waiting for review → [2/14] revised patches waiting for review

Updated

3 months ago
Whiteboard: [2/14] revised patches waiting for review → [2/14] patches r+

Comment 4

3 months ago
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9243ddacadcc
Add FindWithName and FindChildWithName to BrowsingContext. r=peterv

Comment 5

3 months ago
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/996e8765c85a
Test BrowsingContext::FindWithName. r=peterv

Comment 6

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Updated

3 months ago
Whiteboard: [2/14] patches r+
You need to log in before you can comment on or make changes to this bug.