1515662 - android-geckoview-docs is busted

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

I think our docs job is busted, I was digging into TaskCluster to figure out why our docs where not updating and I found this:

[task 2018-12-19T22:08:52.312Z] 22:08:52     INFO -  IOError: [Errno 2] No such file or directory: u'/builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/geckoview/libs/geckoview-javadoc.jar'
[task 2018-12-19T22:08:52.312Z] 22:08:52     INFO -    File "/builds/worker/workspace/build/src/mobile/android/mach_commands.py", line 564, in android_geckoview_docs
[task 2018-12-19T22:08:52.312Z] 22:08:52     INFO -      mozfile.extract_zip(src_tar, dst_path)
[task 2018-12-19T22:08:52.313Z] 22:08:52     INFO -    File "/builds/worker/workspace/build/src/testing/mozbase/mozfile/mozfile/mozfile.py", line 57, in extract_zip
[task 2018-12-19T22:08:52.313Z] 22:08:52     INFO -      bundle = zipfile.ZipFile(src)
[task 2018-12-19T22:08:52.313Z] 22:08:52     INFO -    File "/usr/lib/python2.7/zipfile.py", line 756, in __init__
[task 2018-12-19T22:08:52.313Z] 22:08:52     INFO -      self.fp = open(file, modeDict[mode])

In my local build I see this:

$ find obj-i686-linux-android | grep javadoc.jar
...
obj-i686-linux-android/gradle/build/mobile/android/geckoview/libs/geckoview-66.0.20181219093140-javadoc.jar

We might have changed where we put our javadoc jar (geckoview-<version>-javadoc.jar instead of geckoview-javadoc.jar)

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

It smells like a regression from Bug 1506601.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1515662 - Make |geckoview-docs| behave like other |mach android| commands. r?nalexander!

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1515662 - Copy javadoc jar to right location for publishing. r?nalexander!

In Bug 1506601 we started specifying a version number which made the javadoc
jar artifact name change

from `geckoview-javadoc.jar` to `geckoview-<version>-javadoc.jar`

where `<version>` is the current GeckoView version. This is a good change but it
broke our javadoc publishing code which doesn't know about the version code in
`//taskcluster/ci/build/android-stuff.yml`.

To make that work we add a new task `copyJavadocJar${variantName}` which copies
the jar to the expected location.

Depends on D15128

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8d8dd0f155a
Make |geckoview-docs| behave like other |mach android| commands. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/ea783721ca9e
Copy javadoc jar to right location for publishing. r=nalexander

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f8d8dd0f155a
https://hg.mozilla.org/mozilla-central/rev/ea783721ca9e

Comment 6

[Chris Peterson [:cpeterson]]

65=wontfix because I assume we don't need to uplift this docs job fix to Beta, even though the regression cause bug 1506601 landed in 65.

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

(In reply to Chris Peterson [:cpeterson] from comment #6)
> 65=wontfix because I assume we don't need to uplift this docs job fix to
> Beta, even though the regression cause bug 1506601 landed in 65.

Correct.