1515663 - The "FXA_SNIPPET" is not blocked in the "AS Router" page after the "Sign In" flow is completed

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 64 and above

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have the latest Firefox Nightly build installed.
- Have the "Browser Console" opened.
- Have valid FxA credentials.
- Have a Firefox profile with the following prefs in the "about:config" page:
	- "browser.newtabpage.activity-stream.asrouterExperimentEnabled" with "true" value;

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Navigate to "about:config#asrouter" page.
3. Scroll down to the "FXA_SNIPPET_TEST_1" section and click the "Show" button.
4. Click the stage one button and insert the email from prerequisites in the text field.
5. Click the stage two button and enter the password from prerequisites.
6. Click the "Sign In" button and navigate to the "about:newtab#asrouter" page in a new tab.
7. Scroll down to the "FXA_SNIPPET_TEST_1" section and observe its status.

[Expected result]:
- The "FXA_SNIPPET_TEST_1" section is blocked (grayed out).

[Actual result]:
- The "FXA_SNIPPET_TEST_1" section is still active.

[Additional Notes]:
- This issue is not reproducible with the "Newsletter" and the "SEND_TO_DEVICE" test snippets.
- Attached a screen recording of the issue.

Comment 1

[Nan Jiang [:nanj]]

:andreio, could you investigate this please?

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/c56b04a79e29f55d38c2d0b65e0b5a39fd056719
Fix Bug 1515663 - Block FxA snippet on form submit (#4635)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/bd9fccec51d7

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (66.0a1 Build ID - 20190108215840) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now the snippets are blocked after the "Sign In" flow is completed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something which requires uplift to Beta?

Comment 6

[Andrei Oprea [:andreio]]

No uplift required, thanks. The feature can ride the trains.