1515714 - Menu bar hover feedback lacks contrast on dark titlebar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Liz Henry (:lizzard) (relman/hg->git project)]

Filing a new bug for an issue recently seen by QA from a bug fixed in 2017.

+++

I managed to reproduce this issue again with the latest 65.0b5(20181217180946) build.

I pulled the following regression : https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d8e07613f15e55f43d654af8708ffa0cba1710d1&tochange=d341e1dcdfeff2ba187ada77af2e77f4b430604d 

It seems that the issue which causes this may be Bug 1511905 - Fix window controls' hover and active colors in light titlebars on Windows 10.

Johann, how would you like us to proceed with this issue?


+++ This bug was initially created as a clone of Bug #1368679 +++

Almost I can not recognize the hover effect.

Steps To Reproduce:
1. Enable Menubar
2. Mouse hover over menu or keypress alt key

Actual Results:
Almost I can not recognize active menu.

Expected Results:
More lighter background color.


PS. I think hover active color of caption buttons are also less contrast

Comment 1

[Alice0775 White]

Attachment: Screenshot

I can confirm there are no hover color and active color of menu.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=61571452b0fc8cd26ff55b31e05a76d069883123&tochange=c7443dbcd479b1530466b3d04bba05dc93f4132a

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1515714 - Fix broken selector. r=mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95d09e99337f
Fix broken selector. r=mconley

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/95d09e99337f

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9033435 [details]
Bug 1515714 - Fix broken selector. r=mconley

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1511905

User impact if declined: see comment 1

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Switch to the dark theme, show the menu bar and hover over the menu items

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9033435 [details]
Bug 1515714 - Fix broken selector. r=mconley

[Triage Comment]
Minor CSS fix-up. Approved for 65.0b10.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d9f8c52d4db

Comment 9

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 65.0b9 (BuildId:20190107180200).

This issue is verified fixed using Firefox 66.0a1 (BuildId:20190109214248) and Firefox 65.0b10 (provided in comment 8) on Windows 10 64bit. The hover state for the menu bar elements is successfully visible on default, light and dark themes.

Comment 10

[Peter Magyari (Desktop QA)]

Verified as fixed using Firefox 65.0b10(20190109230104) and Firefox 66.0a1(20190109214248) on Windows 10 x64.