47 bytes, text/x-phabricator-request
|Details | Review|
https://searchfox.org/mozilla-central/rev/232ced2697b8938073fa79b8e6aa3718876c0b69/layout/base/AccessibleCaretManager.cpp#504 clobbers the other two flags declared outside of the ifdef. Does it really want to do that?
Botond, maybe you can provide some context for overriding the other two flags before I dive in?
Indeed, it looks like that should have been an "|=" instead of an "=", i.e. adding that flag instead of overwriting existing flags. My bad!
While testing my patch, the missing FrameForPointOption::IgnoreCrossDoc flags reminds me of bug 1306634 that the focus switching into <iframe> doesn't really work...
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Priority: -- → P4
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9a2751a411f2 Restore two flags passed to GetFrameForPoint() in SelectWordOrShortcut() on Android. r=emilio,botond
You need to log in before you can comment on or make changes to this bug.