1515798 - Convert ui/shared/auth/login.jsx to a reactstrap component

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P5)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This started as me being annoyed by the height of the logged out state being slightly bigger than the height of the logged in state. 

It quickly spiraled into me making it into a reactstrap dropdown...

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: GitHub Pull Request

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 9032819 [details] [review]
GitHub Pull Request

Just requesting a couple tweaks.

Comment 3

[Karl Thiessen [:kthiessen, he/him]]

Wes, any update on this? Should I move it to the backlog, or can we finish it in Q3?

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I don't see myself having time to finish this up anytime soon. It doesn't look like it'd be too much work for someone else to finish up, assuming it isn't going to have too many conflicts once rebased onto master.

Comment 5

[Karl Thiessen [:kthiessen, he/him]]

Thanks for the quick response, Wes. I'm going to set this to P3 (backlog) and leave you as assignee to indicate that anyone who wants to work on it is welcome to, but that they should check in with you to get context first.

Comment 6

[shavindra]

Is this still a valid bug?

Comment 7

[Karl Thiessen [:kthiessen, he/him]]

Cam, is this still something that could be done by a community contributor?

Comment 8

[Cameron Dawson [:camd]]

Sure, yeah. This is something a contributor could do. I'll mark the appropriate fields.

Comment 9

[sumukha214]

Can I start working on this?
as I am new to this community I can start with this issue

Comment 10

[Sarah Clements [:sclements]]

This was resolved in bug 1497931 (https://github.com/mozilla/treeherder/commit/2e7531044c8a7384d2def118d8c89593a5a4e508)