1515814 - Fix SpecialPowers service worker cleanup functions for parent-intercept

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Blake Kaplan (:mrbkap) (inactive)]

SpecialPowers has two functions to clear service workers from a test: removeAllServiceWorkerData and removeServiceWorkerDataForExampleDomain. They directly use an API that accesses the ServiceWorkerManager and that doesn't work in parent-intercept mode. I have a patch that makes SpecialPowers ask the parent to do the work for us.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1515814 - Proxy these calls to the parent. r=asuth

These calls have to happen in the parent process to have any effect. I
experimented with making ServiceWorkerCleanUp.jsm do the remoting itself but
that didn't turn out to be worth the effort and it turns out all of the uses
are currently in the parent process anyway.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1515814 - Ensure that nobody uses this in a child process. r=asuth

This assures us that nobody misuses this code in the wrong process.

Depends on D15160

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=313ec01abad67fb848a3597d79f85c34f1272e1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64e898f29fd8
Proxy these calls to the parent. r=asuth
https://hg.mozilla.org/integration/autoland/rev/bfb1e23872cc
Ensure that nobody uses this in a child process. r=asuth

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/64e898f29fd8
https://hg.mozilla.org/mozilla-central/rev/bfb1e23872cc