Closed Bug 1515821 Opened 10 months ago Closed 10 months ago

438,300 instances of "'NS_FAILED(rv)'" emitted from dom/base/nsContentUtils.cpp during linux64 debug testing

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> 246262 WARNING: 'NS_FAILED(rv)', file dom/base/nsContentUtils.cpp, line 8978

This warning [1] shows up in the following test suites:

>   6975 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
>   6011 - test-linux64/debug-reftest-e10s-3 R3
>   6010 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>   5963 - test-linux64/debug-crashtest-e10s C
>   5493 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
>   4559 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
>   4255 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
>   4195 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
>   4162 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
>   4099 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>   4085 - test-linux64/debug-reftest-e10s-1 R1
>   4080 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>   4046 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
>   4008 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>   3791 - test-linux64/debug-mochitest-e10s-14 14
>   3732 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
>   3710 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>   3694 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>   3578 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
>   3510 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
>   3416 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>   3408 - test-linux64/debug-reftest-e10s-7 R7
>   3405 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>   3369 - test-linux64/debug-reftest-e10s-5 R5
>   3369 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>   3283 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>   3276 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>   3271 - test-linux64/debug-reftest-e10s-2 R2
>   3269 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>   3269 - test-linux64/debug-reftest-e10s-4 R4
>   3245 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
>   3116 - test-linux64/debug-reftest-e10s-6 R6
>   3116 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>   3041 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
>   3011 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
>   2882 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
>   2871 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
>   2854 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
>   2799 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
>   2731 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
>   2694 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
>   2501 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>   2481 - test-linux64/debug-marionette-e10s Mn
>   2480 - test-linux64/debug-marionette-headless-e10s MnH
>   2450 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>   2447 - test-linux64/debug-mochitest-chrome-3 c3
>   2420 - test-linux64/debug-reftest-e10s-8 R8
>   2419 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>   2334 - test-linux64/debug-mochitest-chrome-1 c1
>   2301 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>   2288 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
>   2287 - test-linux64/debug-mochitest-chrome-2 c2
>   1988 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
>   1928 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>   1904 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>   1888 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>   1852 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>   1782 - test-linux64/debug-mochitest-e10s-15 15
>   1763 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>   1711 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>   1682 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>   1642 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
>   1614 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>   1601 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>   1522 - test-linux64/debug-mochitest-e10s-2 2
>   1522 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
>   1509 - test-linux64/debug-mochitest-clipboard-e10s cl
>   1465 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>   1390 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>   1345 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>   1330 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>   1326 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>   1260 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>   1217 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>   1214 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>   1200 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
>   1159 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
>   1077 - test-linux64/debug-mochitest-e10s-5 5
>   1075 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
>   1070 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>   1062 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
>   1049 - test-linux64/debug-mochitest-e10s-9 9
>   1000 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
>    984 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
>    973 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>    923 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
>    913 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
>    910 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
>    893 - test-linux64/debug-mochitest-e10s-13 13
>    878 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
>    864 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
>    802 - test-linux64/debug-mochitest-a11y a11y
>    766 - test-linux64/debug-mochitest-media-e10s-2 mda2
>    758 - test-linux64/debug-mochitest-e10s-8 8
>    738 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
>    705 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>    592 - test-linux64/debug-mochitest-e10s-7 7
>    577 - test-linux64/debug-mochitest-media-e10s-1 mda1
>    573 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
>    564 - test-linux64/debug-mochitest-e10s-4 4
>    556 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
>    476 - test-linux64/debug-mochitest-e10s-12 12
>    455 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
>    366 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
>    365 - test-linux64/debug-mochitest-e10s-1 1
>    324 - test-linux64/debug-mochitest-e10s-16 16
>    304 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
>    304 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
>    300 - test-linux64/debug-mochitest-e10s-10 10
>    297 - test-linux64/debug-mochitest-e10s-3 3
>    297 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
>    279 - test-linux64/debug-mochitest-e10s-11 11
>    275 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
>    272 - test-linux64/debug-mochitest-media-e10s-3 mda3
>    193 - test-linux64/debug-mochitest-e10s-6 6
>    193 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
>    184 - test-linux64/debug-mochitest-gpu-e10s gpu
>    119 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>     84 - test-linux64/debug-telemetry-tests-client-e10s c

It shows up in 44197 tests. A few of the most prevalent:

>  10392 - [e10s] Shutdown
>   1986 -        Shutdown
>   1717 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/dom/base/crashtests/1419902.html
>   1704 - [e10s] layout/style/test/test_transitions_per_property.html
>   1468 - [e10s] parser/htmlparser/tests/mochitest/test_html5_tree_construction.html
>   1356 - [e10s] parser/htmlparser/tests/mochitest/test_html5_tree_construction_part2.html
>   1176 - [e10s] layout/style/test/test_media_queries.html
>    734 - [e10s] dom/tests/browser/browser_noopener.js
>    724 - [e10s] layout/base/tests/test_reftests_with_caret.html
>    638 - [e10s] layout/style/test/test_selectors.html

[1] https://hg.mozilla.org/integration/autoland/annotate/63cbd79e897d/dom/base/nsContentUtils.cpp#l8978
Ehsan it looks like this warning is *extremely* spammy, AFAICT you added it in bug 1508044. It has since gotten much worse:

> 438300 WARNING: 'NS_FAILED(rv)', file dom/base/nsContentUtils.cpp, line 8205
Depends on: 1508044
Flags: needinfo?(ehsan)
Summary: 246,300 instances of "'NS_FAILED(rv)'" emitted from dom/base/nsContentUtils.cpp during linux64 debug testing → 438,300 instances of "'NS_FAILED(rv)'" emitted from dom/base/nsContentUtils.cpp during linux64 debug testing
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #9033029 - Flags: review?(ehsan) → review+
Flags: needinfo?(ehsan)
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a93b82fd06d
Remove verbose warning in IsThirdPartyWindowOrChannel. r=ehsan
https://hg.mozilla.org/mozilla-central/rev/2a93b82fd06d
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.