Closed Bug 1515858 Opened 11 months ago Closed 9 months ago

[wpt-sync] Sync PR 14623 - [LayoutNG] Don't allow line height quirk inside list items.

Categories

(Core :: Layout, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14623 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14623
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Don't allow line height quirk inside list items.
>  
>  This makes us more closely match legacy engine behavior, and both Edge
>  and Firefox have something similar, although Firefox triggers based on
>  element type (LI), and not display type (list-item).
>  
>  This makes the line height difference go away in the test
>  tables/mozilla/bugs/bug23235.html (but note that it will still require a
>  rebaseline, because of minor text rendering differences between legacy
>  and NG).
>  
>  Try toggling display:list-item on and off here:
>  
>  \<!-- quirks mode -->
>  \<div style="display:list-item; line-height:100px; width:100px; background:green;">
>    line\<br>
>    \<div style="display:inline-block; width:100%; height:10px; background:white;">\</div>
>  \</div>
>  
>  Change-Id: I396c0c85454feeaa45a0a5953b9e6b7c475d131e
>  Reviewed-on: https://chromium-review.googlesource.com/1379897
>  WPT-Export-Revision: 465cceabc0d6623e520ed0f1985c913520bbc2c8
Component: web-platform-tests → Layout
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6a8d1fbea4c
[wpt PR 14623] - [LayoutNG] Don't allow line height quirk inside list items., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/b681040ae2ce
[wpt PR 14623] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e820da6c7a2e
[wpt PR 14623] - [LayoutNG] Don't allow line height quirk inside list items., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/861de58e5a3d
[wpt PR 14623] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.