Introduce panel-footer class to fix common color problem with footer buttons

VERIFIED FIXED in Firefox 65

Status

()

defect
P1
normal
VERIFIED FIXED
7 months ago
5 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 unaffected, firefox65 verified, firefox66 verified)

Details

Attachments

(1 attachment)

For now, to address the regressions, I'll use this to share color and background-color only, although there's potential to consolidate and share more things.
Summary: Introduce panel-footer class to fix common color problem with footer button colors → Introduce panel-footer class to fix common color problem with footer buttons
Depends on: 1507109
Component: Theme → Themes
Product: Firefox → Toolkit
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4dc9a08f321
Introduce panel-footer class to fix common color problem with footer buttons. r=ntim
https://hg.mozilla.org/mozilla-central/rev/a4dc9a08f321
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Comment on attachment 9032903 [details]
Bug 1515902 - Introduce panel-footer class to fix common color problem with footer buttons. r=ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1473922

User impact if declined: bug 1509630, bug 1509633, bug 1515671

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: should verify bug 1509630, bug 1509633, bug 1515671

List of other uplifts needed: None

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): fix is pretty straightforward but not particularly small

String changes made/needed:
Attachment #9032903 - Flags: approval-mozilla-beta?
Blocks: 1516085
Blocks: 1516096
Flags: qe-verify+
Comment on attachment 9032903 [details]
Bug 1515902 - Introduce panel-footer class to fix common color problem with footer buttons. r=ntim

[Triage Comment]
Fixes a number of issues with footer buttons. Approved for 65.0b7.
Attachment #9032903 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1516515
Verified on following builds 
Version 	65.0b7
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0


Version 	66.0a1
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0
Blocks: 1518103
Blocks: 1518422
Blocks: 1518431
Blocks: 1518462
Depends on: 1516354
Flags: qe-verify+
Status: RESOLVED → VERIFIED
Depends on: 1527572
You need to log in before you can comment on or make changes to this bug.