Closed
Bug 1515903
Opened 7 years ago
Closed 7 years ago
[autoconfig][regression] Allow image data URLs
Categories
(Thunderbird :: Account Manager, defect)
Tracking
(thunderbird_esr6065+ fixed, thunderbird65 fixed, thunderbird66 fixed)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: BenB, Assigned: BenB)
References
Details
(Keywords: regression)
Attachments
(1 file, 3 obsolete files)
|
2.59 KB,
patch
|
BenB
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Bug 1514628 changed the icon URL from http: to data:image/png;base64... .
However, data: URLs are forbidden, so the addon doesn't show up at all.
data: URLs are highly dangerous in chrome code. They can contain anything, including javascript, e.g. data:text/javascript; and data:text/html; and similar. If these come from the network, and they are run from chrome code, they allow the attacker to run arbitrary code with system privileges, i.e. a remote code execution bug, a critical security bug. These are one of the most dangerous URLs in chrome. These should be avoided at all costs.
However, I guess that data:image/png; and data:image/jpeg; are fine, because they cannot contain JavaScript code.
So, this change opens this up a little bit, allowing specifically these image data: URLs, and only those.
| Assignee | ||
Updated•7 years ago
|
OS: Unspecified → All
Hardware: Unspecified → All
Target Milestone: --- → Thunderbird 66.0
Version: unspecified → 66
| Assignee | ||
Comment 1•7 years ago
|
||
Attachment #9032900 -
Flags: review?(neil)
Comment 2•7 years ago
|
||
Comment on attachment 9032900 [details] [diff] [review]
Fix, v1
r=me with comment nit fixed as discussed.
Attachment #9032900 -
Flags: review?(neil) → review+
| Assignee | ||
Comment 3•7 years ago
|
||
Add comment to explain why not all data:image/ are OK, and SVG cannot be allowed.
| Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 9032926 [details] [diff] [review]
Fix, v2
Carry over Neil r+ from above.
Attachment #9032926 -
Flags: review+
| Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Attachment #9032900 -
Attachment is obsolete: true
| Assignee | ||
Comment 5•7 years ago
|
||
Attachment #9032926 -
Attachment is obsolete: true
Attachment #9032933 -
Flags: review+
Comment 6•7 years ago
|
||
// DANGER ZONE. data:text/javascript or data:text/html run in
^ How about a colon?
// the caller's security context and contain code and might allow
// arbitrary code execution, so these must be prevented at all costs.
Maybe you want to fix the English a bit here and clarify it. Usually a list only uses "and" once, and commas before that. Also, which code does text/html contain? HTML code? How about
... run in the caller's security context, could contain code and might allow arbitrary code execution, ...
Code-wise, all the checks are case sensitive, is that intended?
Comment 7•7 years ago
|
||
Umm, "NeilAway" is some strange IRC nick, wouldn't we just put r=Neil?
| Assignee | ||
Comment 8•7 years ago
|
||
> Code-wise, all the checks are case sensitive, is that intended?
Yes.
Comment fixed.
| Assignee | ||
Comment 9•7 years ago
|
||
Attachment #9032933 -
Attachment is obsolete: true
Attachment #9032940 -
Flags: review+
Comment 10•7 years ago
|
||
Pushed by mozilla.BenB@bucksch.org:
https://hg.mozilla.org/comm-central/rev/1f255495f7a1
[autoconfig] Allow PNG and JPEG image data: URLs. r=Neil
Updated•7 years ago
|
Attachment #9032940 -
Flags: approval-comm-beta+
Comment 11•7 years ago
|
||
Beta (TB 65):
https://hg.mozilla.org/releases/comm-beta/rev/886ee22a3f85d1a7f55c7fa1e5813470be99d88a
status-thunderbird65:
--- → fixed
status-thunderbird66:
--- → fixed
Comment 12•7 years ago
|
||
Beta backout:
https://hg.mozilla.org/releases/comm-beta/rev/195a2aef72e1ab507c07ca93e703600b4b09c3b3
status-thunderbird65:
fixed → ---
Updated•7 years ago
|
Attachment #9032940 -
Flags: approval-comm-esr60?
Comment 13•7 years ago
|
||
TB 65 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/7f685897fe309ac256c3e591e4b14332c536a9e6
status-thunderbird65:
--- → fixed
Comment 14•7 years ago
|
||
Comment on attachment 9032940 [details] [diff] [review]
Fix, v4, with hg header
Using Neil's patch from the try which is rebased.
Attachment #9032940 -
Flags: approval-comm-esr60? → approval-comm-esr60+
Comment 15•7 years ago
|
||
TB 60.5.0 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/3b7edc029d1e33dd69ded77fa83489aede3b70e0
status-thunderbird_esr60:
--- → fixed
tracking-thunderbird_esr60:
--- → 65+
You need to log in
before you can comment on or make changes to this bug.
Description
•