Error in definition of Brazil time zones with DST
Categories
(Calendar :: Lightning Only, defect)
Tracking
(Not tracked)
People
(Reporter: dbastreghi, Assigned: darktrojan)
Details
(Whiteboard: [timezone])
Attachments
(4 files, 2 obsolete files)
458.44 KB,
video/mp4
|
Details | |
1.24 MB,
application/octet-stream
|
Details | |
6.00 KB,
patch
|
darktrojan
:
review+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
15.62 KB,
patch
|
MakeMyDay
:
review+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
Comment 2•6 years ago
|
||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
Let's confirm the problem is the faulty zone information. Here's a copy of Lightning 6.2.4 with the zones fixed. You should be able to install it over the top of the existing one. You'll have to remove it at some point or automatic updates of Lightning will stop happening.
Assignee | ||
Comment 10•6 years ago
|
||
Okay, well that's a start. I opened a bug about it in the upstream tool, but I'm not hopeful of a quick fix. In the meantime I guess we just fix the zones file by hand and try not to break it? What do you think, MMD?
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Can you please reference the upstream bug here? I don't see a related message on the tz mailing list [1]. Is the report about the definition itself? If it is, I'm wondering why this hasn't been detected before - either for Lightning or any other consumer of the olson database, since we use and obtain the current definition for quite some time now.
We can edit zones.json maually to fix the issue, but if so, we should probably fix bug 1502832 to update to the latest definition before and make the update script to issue a warning about the need for postprocessing until upstream fixed the issue.
[1] https://mm.icann.org/pipermail/tz/2019-January/thread.html
Assignee | ||
Comment 12•6 years ago
|
||
It's not the database's fault (AFAICT) but the tool we use to change it to ical format. I'm not really happy using it as it's a revival of a fork of something else, but it's the best we've got.
Here's the issue I should've linked before: https://github.com/benfortuna/tzurl/issues/34
Assignee | ||
Comment 13•6 years ago
|
||
I see no better way to fix this for now.
Comment 14•6 years ago
|
||
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 17•6 years ago
|
||
Can you please crosscheck the tz update - something is fishy, Asia/Tokyo got removed the tzname.
Assignee | ||
Comment 18•6 years ago
|
||
I noticed that and didn't check it. :-/
Comment 19•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 20•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/88b96d287e79
Fix broken definition of Brazil time zones with DST. r=MakeMyDay
Comment 22•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/6b7f5a396d0a
Update timezone definitions to version 2018i. r=MakeMyDay
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 23•6 years ago
|
||
TB 66 beta 3 / Cal 6.8:
https://hg.mozilla.org/releases/comm-beta/rev/080b31a50795e4f47ca3243fde40de737c0b4d9b
https://hg.mozilla.org/releases/comm-beta/rev/be2271f3fd5236dfc01d810e1fe67ce5405bcfab
Comment 24•6 years ago
|
||
TB 60.6 ESR / Cal 6.2.6:
https://hg.mozilla.org/releases/comm-esr60/rev/44e0003b094a042ec730b6fa62bc7e5d9dd46040
https://hg.mozilla.org/releases/comm-esr60/rev/979d7bb0b5a39a9205d638afb4cc75f1235cf7b8
Description
•