Closed Bug 1515939 Opened 4 years ago Closed 4 years ago

Fix styling of the submenu used to add new search engines

Categories

(Firefox :: Search, defect, P1)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- fixed
firefox66 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1515939 - Fix styling of the submenu used to add new search engines. r=dao
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review 
Some classes went missing in bug 1493536.
[Tracking Requested - why for this release]:
status-firefox65: --- → affected
status-firefox66: --- → affected
Keywords: regression
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f711b70e09ee
Fix styling of the submenu used to add new search engines. r=dao
https://hg.mozilla.org/mozilla-central/rev/f711b70e09ee
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Please request Beta approval on this when you get a chance.
status-firefox64: --- → unaffected
status-firefox-esr60: --- → unaffected
Flags: needinfo?(paolo.mozmail)
Comment on attachment 9032939 [details]
Bug 1515939 - Fix styling of the submenu used to add new search engines. r=dao

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1493536

User impact if declined: Incorrect styling of the submenu used to add new search engines

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This trivial fix restores a class used by CSS for styling.

String changes made/needed: None
Flags: needinfo?(paolo.mozmail)
Attachment #9032939 - Flags: approval-mozilla-beta?
Comment on attachment 9032939 [details]
Bug 1515939 - Fix styling of the submenu used to add new search engines. r=dao

[Triage Comment]
Trivial styling fix. Approved for 65.0b8.
Attachment #9032939 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.