Enable ESLint for gfx/

RESOLVED FIXED in Firefox 66

Status

()

RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(3 attachments)

As part of rolling out ESLint across the tree, we should enable it for gfx.

I've had a parch series around for a while now, not quite sure when I started it. However, its time to see about landing it.

The only thing that's missing is to enable no-undef for gfx/layers/apz/test/mochitest/**. I think we might need some tweaks to the ESLint module for that, I'll file a follow-up about it.
Created attachment 9032952 [details]
Bug 1515942 - Enable ESLint for gfx/ (fix quotes only). r?jrmuizel

This changes single quotes to double quotes in one patch to match our ESLint rules.
This used ESLint's automatic fixing.
Created attachment 9032954 [details]
Bug 1515942 - Enable ESLint for gfx/ (automatic fixes). r?jrmuizel

Depends on D15204
Created attachment 9032955 [details]
Bug 1515942 - Enable ESLint for gfx/ (manual fixes). r?kats

Depends on D15205
Attachment #9032955 - Attachment description: Bug 1515942 - Enable ESLint for gfx/ (manual fixes). r?jrmuizel → Bug 1515942 - Enable ESLint for gfx/ (manual fixes). r?kats

Comment 6

2 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/486d4df8ab20
Enable ESLint for gfx/ (fix quotes only). r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cda72b927c04
Enable ESLint for gfx/ (automatic fixes). r=kats
https://hg.mozilla.org/integration/autoland/rev/d6c5ea714d9d
Enable ESLint for gfx/ (manual fixes). r=kats

Comment 7

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/486d4df8ab20
https://hg.mozilla.org/mozilla-central/rev/cda72b927c04
https://hg.mozilla.org/mozilla-central/rev/d6c5ea714d9d
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.