1515942 - Enable ESLint for gfx/

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mark Banner (:standard8)]

As part of rolling out ESLint across the tree, we should enable it for gfx.

I've had a parch series around for a while now, not quite sure when I started it. However, its time to see about landing it.

The only thing that's missing is to enable no-undef for gfx/layers/apz/test/mochitest/**. I think we might need some tweaks to the ESLint module for that, I'll file a follow-up about it.

Comment 1

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=80a97638f9556f3d45f5d73091404e77e7271aae

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1515942 - Enable ESLint for gfx/ (fix quotes only). r?jrmuizel

This changes single quotes to double quotes in one patch to match our ESLint rules.
This used ESLint's automatic fixing.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1515942 - Enable ESLint for gfx/ (automatic fixes). r?jrmuizel

Depends on D15204

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1515942 - Enable ESLint for gfx/ (manual fixes). r?kats

Depends on D15205

Comment 5

[Mark Banner (:standard8)]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4584d113a694f10bd6c23c65186a41d15592af8c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/486d4df8ab20
Enable ESLint for gfx/ (fix quotes only). r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cda72b927c04
Enable ESLint for gfx/ (automatic fixes). r=kats
https://hg.mozilla.org/integration/autoland/rev/d6c5ea714d9d
Enable ESLint for gfx/ (manual fixes). r=kats

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/486d4df8ab20
https://hg.mozilla.org/mozilla-central/rev/cda72b927c04
https://hg.mozilla.org/mozilla-central/rev/d6c5ea714d9d