Closed Bug 1515943 Opened 10 months ago Closed 8 months ago

No telemetry events are generated if the "Learn more..." link is opened from context menu or using middle click

Categories

(Firefox :: Security, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Tracking Status
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- verified

People

(Reporter: carmenf, Assigned: srestha, Mentored)

References

Details

Attachments

(5 files)

Attached image telemetry click.gif
[Affected versions]:
- Firefox 64.0 and above

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have the latest Firefox Release (64.0) build installed.
- Have  "browser.security.newcerterrorpage.enabled"  pref set to "true" in "about:config" page.
	
[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Navigate to https://untrusted-root.badssl.com/ website.
3. Middle click the "Learn more..." link.
4. Navigate to "about:telemetry#events-tab" page.
5. Click the "content" option from the "parent" drop-down menu.
6. Observe if the "learn_more_link" event was generated.

[Expected result]:
- The "learn_more_link" event is generated.

[Actual result]:
- The "learn_more_link" event is not generated.

[Notes]:
- The issue is also reproducible if the link is opened using the context menu triggered by right click.
- This issue is also reproducible with the other new certificate error pages (both bypassable and non-bypassable):
SEC_ERROR_UNKNOWN_ISSUER
SSL_ERROR_BAD_CERT_DOMAIN
SEC_ERROR_EXPIRED_CERTIFICATE
- Attached a screen recording with the issue.
Priority: -- → P3

The problem here is that we only record clicks when the event.button attribute is 0, I think:

https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/actors/NetErrorChild.jsm#621

We should probably record the click for any button types.

Mentor: jhofmann

I would like to start working on this one. Could you please assign it to me?

file:///home/srestha/Pictures/Screenshot%20from%202019-02-26%2008-06-56.png

Attachment #9046462 - Attachment description: Bug 1515943 telemetry events are generated if the Learn more... link is opened from context menu or using middle click → Bug 1515943 telemetry events are generated if the Learn more... link is opened from context menu or using middle click r=johannh
Attachment #9046469 - Attachment description: Bug 1515943 telemetry events are generated if the Learn more... link is opened from context menu or using middle click → Bug 1515943 telemetry events are generated if the Learn more... link is opened from context menu or using middle click r=johnnah
Assignee: nobody → sresthasrivastava.ss
Status: NEW → ASSIGNED
Attachment #9046469 - Attachment description: Bug 1515943 telemetry events are generated if the Learn more... link is opened from context menu or using middle click r=johnnah → Bug 1515943 telemetry events are generated if the Learn more... link is opened from context menu or using middle click

Depends on D21068

Attachment #9046673 - Attachment description: Bug 1515943 Fixed the linting errors → Bug 1515943 Fixed the linting errors r=johannh
Attached file Bug 1515943

Depends on D21068

Attachment #9046469 - Attachment description: Bug 1515943 telemetry events are generated if the Learn more... link is opened from context menu or using middle click → Bug 1515943 - Generate telemetry events from context menu or middle click on cert error pages. r=johannh

Hey I've added the check-in needed flag. Why is it still not checked-in?

That was not the right field, you just tagged comment 5 :)

Keywords: checkin-needed

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/c134bc3933e6
Generate telemetry events from context menu or middle click on cert error pages. r=johannh CLOSED TREE

Keywords: checkin-needed

@johannh,is there a bug that I can take? Also how do I self-assign a bug?

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Is this something we want in 66 when the new pages are preffed on?

(In reply to Julien Cristau [:jcristau] from comment #13)

Is this something we want in 66 when the new pages are preffed on?

The event telemetry is only enabled in pre-release, so not worth the effort.

Thanks for checking, though :)

Flags: needinfo?(jhofmann)

So it turns out that we do record this on release (thanks to Julien pointing this out on IRC), but this fix is still not important enough for a late uplift, IMO.

I have reproduced this bug with Nightly 66.0a1 (2018-12-28) on Windows 7, 64 Bit. This bug's fix is verified with latest Nightly!

Build ID : 20190304093752
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

QA Whiteboard: [bugday-20190227]

I will mark this bug as Verified Fixed as per comment 16.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.