Open Bug 1515969 Opened 6 years ago Updated 3 years ago

Investigate if camera::BrowserEngine webrtc.org code is unused, so we can remove it

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox66 --- affected

People

(Reporter: jib, Unassigned)

Details

Can we remove code? Spotted in review https://phabricator.services.mozilla.com/D14941#inline-82271 We use our own MediaEngineTabVideoSource to handle our behind-pref tab-sharing code, instead of using the upstream webrtc.org code for this. We overload the camera::BrowserEngine enum for this here [1]. At the same time, a search [2] reveals we still start code in CamerasParent based on camera::BrowserEngine. [1] https://searchfox.org/mozilla-central/rev/413dd3a1fab3446749f3690d93ee17e3196f8c37/dom/media/webrtc/MediaEngineWebRTC.cpp#156-157 [2] https://searchfox.org/mozilla-central/search?q=symbol:E_%3CT_mozilla%3A%3Acamera%3A%3ACaptureEngine%3E_BrowserEngine&redirect=false
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.