Closed Bug 1515978 Opened 2 years ago Closed 2 years ago

[api] GeckoRuntimeSettings#getSettings should be @NonNull

Categories

(GeckoView :: General, enhancement, P2)

All
Android
enhancement

Tracking

(geckoview64 wontfix, geckoview65 wontfix, geckoview66 fix-optional, firefox64 wontfix, firefox65 wontfix, firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
geckoview64 --- wontfix
geckoview65 --- wontfix
geckoview66 --- fix-optional
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: agi, Assigned: agi)

Details

Attachments

(1 file, 1 obsolete file)

Reported by :sebastian, GeckoRuntimeSettings#getSettings can never be null so we should mark it as @NonNull
Attachment #9034014 - Attachment is obsolete: true
Attachment #9032988 - Attachment description: Bug 1515978 - Make GeckoRuntime#getSettings @NonNull. → Bug 1515978 - Make GeckoRuntime#getSettings @NonNull. r?droeh!
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20eca8ed41e6
Make GeckoRuntime#getSettings @NonNull. r=geckoview-reviewers,droeh
https://hg.mozilla.org/mozilla-central/rev/20eca8ed41e6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
OS: Mac OS X → Android
Hardware: x86_64 → All
You need to log in before you can comment on or make changes to this bug.