[api] GeckoRuntimeSettings#getSettings should be @NonNull

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: agi, Assigned: agi)

Tracking

unspecified
mozilla66
All
Android

Firefox Tracking Flags

(geckoview64 wontfix, geckoview65 wontfix, geckoview66 fix-optional, firefox64 wontfix, firefox65 wontfix, firefox66 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reported by :sebastian, GeckoRuntimeSettings#getSettings can never be null so we should mark it as @NonNull
Attachment #9034014 - Attachment is obsolete: true
Attachment #9032988 - Attachment description: Bug 1515978 - Make GeckoRuntime#getSettings @NonNull. → Bug 1515978 - Make GeckoRuntime#getSettings @NonNull. r?droeh!
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20eca8ed41e6
Make GeckoRuntime#getSettings @NonNull. r=geckoview-reviewers,droeh
https://hg.mozilla.org/mozilla-central/rev/20eca8ed41e6
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
OS: Mac OS X → Android
Hardware: x86_64 → All
You need to log in before you can comment on or make changes to this bug.